Skip to content

Expand TetrAMM to make use of available stats. #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DiamondJoseph opened this issue Feb 15, 2024 · 2 comments · May be fixed by #1272
Open

Expand TetrAMM to make use of available stats. #337

DiamondJoseph opened this issue Feb 15, 2024 · 2 comments · May be fixed by #1272
Labels
enhancement New feature or request i22

Comments

@DiamondJoseph
Copy link
Contributor

DiamondJoseph commented Feb 15, 2024 •
edited
Loading

Below code removed from TetrAMMDetector type created for i22's current monitor.

    # self.current_1 = ad_r(float, prefix + ":Cur1:MeanValue")
    # self.current_2 = ad_r(float, prefix + ":Cur2:MeanValue")
    # self.current_3 = ad_r(float, prefix + ":Cur3:MeanValue")
    # self.current_4 = ad_r(float, prefix + ":Cur4:MeanValue")

    # self.position_x = ad_r(float, prefix + ":PosX:MeanValue")
    # self.position_y = ad_r(float, prefix + ":PosY:MeanValue")

May require changes to ophyd_async to pass Readable signals down to the HDFWriter: these signals are prefixed without the :DRV of the Driver.

Acceptance Criteria

  • TetrAMM can be created that when read also provides MeanValue readings.
@DiamondJoseph DiamondJoseph changed the title Expand TetrAMM detector to make use of available stats. Expand TetrAMM to make use of available stats. Feb 15, 2024
@DiamondJoseph DiamondJoseph mentioned this issue Feb 15, 2024
Closed
2 tasks
@joeshannon joeshannon mentioned this issue Apr 9, 2024
Closed
@stan-dot stan-dot added enhancement New feature or request i22 labels Dec 2, 2024
@stan-dot
Copy link
Contributor

stan-dot commented Dec 2, 2024

@DiamondJoseph what plan would use it?

@DiamondJoseph
Copy link
Contributor Author

Any plan that currently uses the TetrAMM

@DiamondJoseph DiamondJoseph linked a pull request Jun 10, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request i22
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refresh i22 devices with lessons learned from ophyd-async developments DiamondLightSource/dodal
2 participants
@DiamondJoseph @stan-dot