Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ispyb.open causes ispyb.model deprecation warning #179

Open
ndevenish opened this issue May 22, 2022 · 0 comments
Open

Using ispyb.open causes ispyb.model deprecation warning #179

ndevenish opened this issue May 22, 2022 · 0 comments

Comments

@ndevenish
Copy link
Collaborator

ispyb.open imports:

from ispyb.connector.mysqlsp.main import ISPyBMySQLSPConnector as Connector

This imports ispyb.interface.connection:

import ispyb.interface.connection

and this imports ispyb.model:

import ispyb.model.interface

Thus, you cannot use ispyb.open without getting the warning:

warnings.warn(
"ispyb.model has been deprecated and will be removed in a future version. "
"You can use the SQLAlchemy models in ispyb.sqlalchemy instead",
DeprecationWarning,
stacklevel=2,
)

Are all non-sqlalchemy connection deprecated, or just ispyb.model? (AFAIK the sqlalchemy credentials don't have stored procedure access or insertion/update permissions, to get the same results - the credentials I am aware of can only see the update_session_archived procedure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant