Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by making a none multi threaded version of IString::itern #18

Open
gkorland opened this issue Jan 18, 2022 · 2 comments

Comments

@gkorland
Copy link
Contributor

From running some profiling it seems like most of the performance impact vs serde_json is related to the IString::itern.

And most of the overhead is due to the multi threaded code (i.e. locks)

image

image

@Diggsey
Copy link
Owner

Diggsey commented Jan 18, 2022

Interesting... It would be possible to make the types in this crate !Send unless a feature flag is enabled.

It might also be worth looking at how to improve the multithreaded performance - eg. dashmap 5.x uses parking_lot instead of its own custom lock implementation, so that might provide some performance benefit.

@gkorland
Copy link
Contributor Author

I tried to upgrade to dashmap 5 but didn't see any impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants