fix: iron out warnings/errors/deprecations from PHP 8.0 upgrade #1384 (#1402)

* fix: return -1, 0, 1 from uksort and uasort callbacks

* fix: deprecated parameter order from PHP8

Author: squigglybob

archive-template.php

@@ -459,7 +459,7 @@ class="second-bar show-for-small-only center list-actions-bar"><!--  /* MOBILE V
                                             if ( isset( $b["show_in_table"] ) ){
                                                 $b_order = is_numeric( $b["show_in_table"] ) ? $b["show_in_table"] : 90;
                                             }
-                                            return $a_order > $b_order;
+                                            return $a_order <=> $b_order;
                                         });
                                         foreach ( $post_settings["fields"] as $field_key => $field_value ){
                                             if ( ( isset( $field_value["show_in_table"] ) && $field_value["show_in_table"] ) ){

dt-contacts/access-module.php

@@ -351,7 +351,7 @@ public function dt_custom_fields_settings( $fields, $post_type ){
 
             //order overall status options
             uksort( $declared_fields["overall_status"]["default"], function ( $a, $b ) use ( $fields ){
-                return array_search( $a, array_keys( $fields["overall_status"]["default"] ) ) > array_search( $b, array_keys( $fields["overall_status"]["default"] ) );
+                return array_search( $a, array_keys( $fields["overall_status"]["default"] ) ) <=> array_search( $b, array_keys( $fields["overall_status"]["default"] ) );
             } );
             $fields = $declared_fields;
         }

dt-core/libraries/posts-to-posts/vendor/scribu/scb-framework/Cron.php

@@ -21,7 +21,11 @@ class scbCron {
 	 *
 	 * @return void
 	 */
-	public function __construct( $file = false, $args ) {
+	public function __construct( $file = false, $args = array() ) {
+
+		if ( empty( $args ) ) {
+			return;
+		}
 
 		// Set time & schedule
 		if ( isset( $args['time'] ) ) {

dt-core/libraries/posts-to-posts/vendor/scribu/scb-framework/Forms.php

@@ -62,7 +62,7 @@ public static function form_table( $rows, $formdata = null ) {
 	 *
 	 * @return string
 	 */
-	public static function form( $inputs, $formdata = null, $nonce ) {
+	public static function form( $inputs, $formdata = null, $nonce = 'update_options' ) {
 		$output = '';
 		foreach ( $inputs as $input ) {
 			$output .= self::input( $input, $formdata );
@@ -1045,4 +1045,3 @@ public function validate( $value ) {
 		return call_user_func( $this->sanitize, $value, $this );
 	}
 }
-