-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ds produces unexpected check.mono warnings #186
Comments
I have tagged @fpetersma for your comments, Felix. |
Amazing that the duiker dataset just keeps on throwing up challenges. Do the rest of the candidate model set with adjustments also misbehave? |
No, just this one. I suspect it's pointing up a wider problem with the constraint-checking locations (distances) when there is left truncation being different in the optimizer vs the after-fitting checker -- but I could easily be wrong about that. |
There it is: the first bug. The day we all knew would come. I will try to find some time soon to look into it and see if I can figure out, but like you said, it seems like it has to do with how check.mono and the fitting select points. If that turns out to be the cause, then I do have a follow up question: what is the right way to treat the detection function part on the left side of the left truncation? Is it a problem if it does something odd, like be larger than one, for distances that are not used anyway? It seems to me that we don't really care what happens to the detection function to the right of the width, or at least, we don't include point past the width for monotonicity checks -- does that apply to the left side as well? |
Using
Distance
2.0.0 andmrds
3.0.0.The following code uses these duiker data: DaytimeDistances.txt
This produces the following output:
However, the fitted detection function looks fine:
It's possible perhaps that the issue is to do with left truncation, and that the detection function goes marginally above 1 at distances less than the left truncation distance
Here is a check of that
Yes, that seems to be it. I'll post as an issue and perhaps we can discuss how this arises -- perhaps the bounds within the optimizer are not the same as those in check.mono, perhaps just for left truncated data?
The text was updated successfully, but these errors were encountered: