Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monotonicity constraint consistency between mrds and Distance for Windows #62

Open
dill opened this issue Oct 12, 2022 · 2 comments
Open
Assignees
Milestone

Comments

@dill
Copy link
Contributor

dill commented Oct 12, 2022

Per discussion here:

@lenthomas:

"Regarding the points at which to check for constraints, do you think I should change mcds.exe so that it also takes account of left truncation? It makes sense to me, as g(x) for 0 >= x >= [left trucation point] should be 0 when it comes to things like calculating average p so no point in checking for non-monotonicity there."

and

"[in mrds] there is a monotonicity check at 20 evenly spaced points between the left and right truncation points. This seems inconsistent with the constrained optimization that is done, where monotonicity is checked at 10 non-evenly spaced points between left and right truncation. Shouldn't these be consistent?"

@dill
Copy link
Contributor Author

dill commented Nov 3, 2022

Check FORTRAN code, see if R does the same.

@dill dill added this to the mrds 2.3.0 milestone Nov 3, 2022
@dill dill self-assigned this Nov 22, 2022
@dill dill removed their assignment Dec 6, 2022
@LHMarshall LHMarshall assigned LHMarshall and lenthomas and unassigned LHMarshall May 26, 2023
@lenthomas lenthomas modified the milestones: mrds 2.3.0, mrds 2.3.1 Jun 13, 2023
@lenthomas
Copy link
Member

lenthomas commented Jun 13, 2023

Decision at May 3rd Dist Dev meeting is to make the two consistent; we didn't finalize which to change, but it seems to make more sense a priori to have more constraint points rather than fewer. If this is an mrds change it may warrant a minor version bump rather than a patch - so I assigned to 2.4.0.

@lenthomas lenthomas modified the milestones: mrds 2.3.1, mrds 2.4.0 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants