Cist: flattened ranks flatten S. Agnes (ij. Vespers) against SS. Vinc. and Anast. (iij. Lect.), which is unacceptable

[Augustinus-Altovadensis]

Laudétur Jesus Christus!

As the title says, the situation is that in a commit, that I have just PR'ed, there is St. Agnes:
01-21.txt
[Rank] (rubrica cisterciensis)
S. Agnetis, Virginis et Martyris;;xij. Lect. et M.;;2.3;;vide C6b

and Sts. Vincent and Anastasius:
01-22.txt
[Rank] (rubrica cisterciensis)
SS. Vincentii et Anastasii, Martyrum;;iij. Lect. et M.;;1.2;;vide C3

In a normal world, and according to the rubrics, second Vespers of St. Agnes should clearly be the main Office with Sts. Vinc. and Anast. commemorated. However, for some reason, the flattening of ranks in horascommon.pl on line 933 and further does something different and Sts. Vincent and Anastasius end up winning with the a capitulo a sequenti comment.

If I switch off either of the flattened variables in lines 936 or 945, the program works correctly, however this flattening of ranks can be sometimes useful, so I don't want to simply switch off... However this behaviour is wrong.

@FAJ-Munich: sorry to bother you again, could you fix the function, so that for the Cistercian rite, it works only on Sundays?

Thanks a lot, God bless!

[FAJ-Munich]

Let me check on the "a capitulo" issue; sounds weird for a "Semiduplex/xij. Lect." to give way to a "Simplex/iij. Lect."

On a side note, I know that at some obscure places in the code, the values between the first and second ;; is checked and does not know how to handle the Cistercian rank names. So in the database, it would be better to keep the Roman equivalents "Duplex / Semiduplex / Simplex " etc. unless some unexpected behaviour might happen

[FAJ-Munich]

PR #4338

[Augustinus-Altovadensis]

Thank you!
Very good. I used that $dayname[1] value as an additional check to write somewhere in words the rank of the feast, and in a way also to show me that I have already seen and adapted that file. Never mind, I will leave it in the Roman way for now. Thanks for pointing that out.