Skip to content

Commit 95bd2bb

Browse files
committed
remove input interface [FoKE-Developers#61]
- 삭제 사유 - domain module에서 input interface를 두어 의존성 역전을 해서 사용중 - 하지만 Hilt를 사용해서 UseCase를 의존성 주입해서 사용중인데 input interface로 다시 의존성 역전하고 이를 Bind하는 것이 burden이라 판단
1 parent f2c5390 commit 95bd2bb

File tree

10 files changed

+14
-74
lines changed

10 files changed

+14
-74
lines changed

domain/src/main/java/com/foke/together/domain/input/GetCameraSourceTypeInterface.kt

Lines changed: 0 additions & 8 deletions
This file was deleted.

domain/src/main/java/com/foke/together/domain/input/GetExternalCameraIPInterface.kt

Lines changed: 0 additions & 8 deletions
This file was deleted.

domain/src/main/java/com/foke/together/domain/input/SetCameraSourceTypeInterface.kt

Lines changed: 0 additions & 7 deletions
This file was deleted.

domain/src/main/java/com/foke/together/domain/input/SetExternalCameraIPInterface.kt

Lines changed: 0 additions & 7 deletions
This file was deleted.

domain/src/main/java/com/foke/together/domain/input/di/UseCaseModule.kt

Lines changed: 0 additions & 24 deletions
This file was deleted.
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.foke.together.domain.interactor
22

3-
import com.foke.together.domain.input.GetCameraSourceTypeInterface
43
import com.foke.together.domain.interactor.entity.CameraSourceType
54
import com.foke.together.domain.output.AppPreferenceInterface
65
import kotlinx.coroutines.flow.Flow
@@ -9,7 +8,7 @@ import javax.inject.Inject
98

109
class GetCameraSourceTypeUseCase @Inject constructor(
1110
private val appPreference: AppPreferenceInterface
12-
): GetCameraSourceTypeInterface {
13-
override operator fun invoke(): Flow<CameraSourceType> =
11+
) {
12+
operator fun invoke(): Flow<CameraSourceType> =
1413
appPreference.getCameraSourceType().map { it }
1514
}

domain/src/main/java/com/foke/together/domain/interactor/GetExternalCameraIPUseCase.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.foke.together.domain.interactor
22

3-
4-
import com.foke.together.domain.input.GetExternalCameraIPInterface
53
import com.foke.together.domain.interactor.entity.ExternalCameraIP
64
import com.foke.together.domain.output.AppPreferenceInterface
75
import kotlinx.coroutines.flow.Flow
@@ -10,8 +8,8 @@ import javax.inject.Inject
108

119
class GetExternalCameraIPUseCase @Inject constructor(
1210
private val appPreference: AppPreferenceInterface
13-
): GetExternalCameraIPInterface {
14-
override operator fun invoke(): Flow<ExternalCameraIP> =
11+
) {
12+
operator fun invoke(): Flow<ExternalCameraIP> =
1513
appPreference.getExternalCameraIP().map { it }
1614
}
1715

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
package com.foke.together.domain.interactor
22

3-
import com.foke.together.domain.input.SetCameraSourceTypeInterface
43
import com.foke.together.domain.interactor.entity.CameraSourceType
54
import com.foke.together.domain.output.AppPreferenceInterface
65
import javax.inject.Inject
76

87
class SetCameraSourceTypeUseCase @Inject constructor(
98
private val appPreference: AppPreferenceInterface
10-
): SetCameraSourceTypeInterface {
11-
override suspend operator fun invoke(cameraSourceType: CameraSourceType) =
9+
) {
10+
suspend operator fun invoke(cameraSourceType: CameraSourceType) =
1211
appPreference.setCameraSourceType(cameraSourceType)
1312
}

domain/src/main/java/com/foke/together/domain/interactor/SetExternalCameraIPUseCase.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
package com.foke.together.domain.interactor
22

3-
4-
import com.foke.together.domain.input.SetExternalCameraIPInterface
53
import com.foke.together.domain.interactor.entity.ExternalCameraIP
64
import com.foke.together.domain.output.AppPreferenceInterface
75
import javax.inject.Inject
86

97
class SetExternalCameraIPUseCase @Inject constructor(
108
private val appPreference: AppPreferenceInterface
11-
): SetExternalCameraIPInterface {
12-
override suspend operator fun invoke(externalCameraIP: ExternalCameraIP)=
9+
) {
10+
suspend operator fun invoke(externalCameraIP: ExternalCameraIP)=
1311
appPreference.setExternalCameraIP(externalCameraIP)
1412
}
1513

presenter/src/main/java/com/foke/together/presenter/viewmodel/SettingViewModel.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ package com.foke.together.presenter.viewmodel
22

33
import androidx.lifecycle.ViewModel
44
import androidx.lifecycle.viewModelScope
5-
import com.foke.together.domain.input.GetCameraSourceTypeInterface
6-
import com.foke.together.domain.input.SetCameraSourceTypeInterface
5+
import com.foke.together.domain.interactor.GetCameraSourceTypeUseCase
6+
import com.foke.together.domain.interactor.SetCameraSourceTypeUseCase
77
import com.foke.together.domain.interactor.entity.CameraSourceType
88
import com.foke.together.util.AppLog
99
import dagger.hilt.android.lifecycle.HiltViewModel
@@ -16,10 +16,10 @@ import javax.inject.Inject
1616

1717
@HiltViewModel
1818
class SettingViewModel @Inject constructor(
19-
private val getCameraSourceTypeInterface: GetCameraSourceTypeInterface,
20-
private val setCameraSourceTypeInterface: SetCameraSourceTypeInterface
19+
getCameraSourceTypeUseCase: GetCameraSourceTypeUseCase,
20+
private val setCameraSourceTypeUseCase: SetCameraSourceTypeUseCase
2121
): ViewModel() {
22-
val cameraSourceType = getCameraSourceTypeInterface().shareIn(
22+
val cameraSourceType = getCameraSourceTypeUseCase().shareIn(
2323
scope = viewModelScope,
2424
started = SharingStarted.WhileSubscribed(5000),
2525
replay = 1
@@ -36,7 +36,7 @@ class SettingViewModel @Inject constructor(
3636
fun setCameraSourceType(type: CameraSourceType){
3737
viewModelScope.launch {
3838
AppLog.e(TAG, "setCameraSourceType", "type: $type")
39-
setCameraSourceTypeInterface(type)
39+
setCameraSourceTypeUseCase(type)
4040
}
4141
}
4242

0 commit comments

Comments
 (0)