Revert removal final newline (open-telemetry#5133)

* Revert removal final newline

* Add to final newlin editorconfigoverride

Author: jack-berg

.editorconfig

@@ -3,7 +3,7 @@ charset = utf-8
 end_of_line = lf
 indent_size = 2
 indent_style = space
-insert_final_newline = false
+insert_final_newline = true
 max_line_length = 100
 tab_width = 2
 ij_continuation_indent_size = 4

all/build.gradle.kts

@@ -113,4 +113,4 @@ tasks.named<JacocoReport>("jacocoTestReport") {
     // without any external tools
     html.required.set(true)
   }
-}
+}

api/all/build.gradle.kts

@@ -22,4 +22,4 @@ dependencies {
 tasks.test {
   // Configure environment variable for ConfigUtilTest
   environment("CONFIG_KEY", "environment")
-}
+}

api/logs/build.gradle.kts

@@ -10,4 +10,4 @@ otelJava.moduleName.set("io.opentelemetry.api.logs")
 
 dependencies {
   api(project(":api:all"))
-}
+}

build.gradle.kts

@@ -72,4 +72,4 @@ tasks {
       }
     }
   }
-}
+}

buildSrc/build.gradle.kts

@@ -11,6 +11,7 @@ spotless {
       "indent_size" to "2",
       "continuation_indent_size" to "2",
       "max_line_length" to "160",
+      "insert_final_newline" to "true",
       "ktlint_standard_no-wildcard-imports" to "disabled",
       // ktlint does not break up long lines, it just fails on them
       "ktlint_standard_max-line-length" to "disabled",
@@ -61,4 +62,4 @@ tasks {
       release.set(8)
     }
   }
-}
+}

buildSrc/src/main/kotlin/otel.animalsniffer-conventions.gradle.kts

@@ -17,4 +17,4 @@ animalsniffer {
 tasks.withType<AnimalSniffer> {
   // always having declared output makes this task properly participate in tasks up-to-date checks
   reports.text.required.set(true)
-}
+}

buildSrc/src/main/kotlin/otel.bom-conventions.gradle.kts

@@ -68,4 +68,4 @@ afterEvaluate {
       }
     }
   }
-}
+}

buildSrc/src/main/kotlin/otel.errorprone-conventions.gradle.kts

@@ -112,4 +112,4 @@ tasks {
       }
     }
   }
-}
+}

buildSrc/src/main/kotlin/otel.jacoco-conventions.gradle.kts

@@ -50,4 +50,4 @@ configurations {
       outgoing.artifact(the<JacocoTaskExtension>().destinationFile!!)
     }
   }
-}
+}

buildSrc/src/main/kotlin/otel.japicmp-conventions.gradle.kts

@@ -143,4 +143,4 @@ if (!project.hasProperty("otel.release") && !project.name.startsWith("bom")) {
       }
     }
   }
-}
+}

buildSrc/src/main/kotlin/otel.java-conventions.gradle.kts

@@ -240,4 +240,4 @@ testing {
       }
     }
   }
-}
+}

buildSrc/src/main/kotlin/otel.jmh-conventions.gradle.kts

@@ -35,4 +35,4 @@ tasks {
 
     outputs.cacheIf { false }
   }
-}
+}

buildSrc/src/main/kotlin/otel.protobuf-conventions.gradle.kts

@@ -33,4 +33,4 @@ afterEvaluate {
     add("compileProtoPath", platform(project(":dependencyManagement")))
     add("testCompileProtoPath", platform(project(":dependencyManagement")))
   }
-}
+}

buildSrc/src/main/kotlin/otel.publish-conventions.gradle.kts

@@ -62,4 +62,4 @@ if (System.getenv("CI") != null) {
     useInMemoryPgpKeys(System.getenv("GPG_PRIVATE_KEY"), System.getenv("GPG_PASSWORD"))
     sign(publishing.publications["mavenPublication"])
   }
-}
+}

buildSrc/src/main/kotlin/otel.spotless-conventions.gradle.kts

@@ -26,6 +26,7 @@ spotless {
         "indent_size" to "2",
         "continuation_indent_size" to "2",
         "max_line_length" to "160",
+        "insert_final_newline" to "true",
         "ktlint_standard_no-wildcard-imports" to "disabled",
         // ktlint does not break up long lines, it just fails on them
         "ktlint_standard_max-line-length" to "disabled",
@@ -42,6 +43,7 @@ spotless {
       "indent_size" to "2",
       "continuation_indent_size" to "2",
       "max_line_length" to "160",
+      "insert_final_newline" to "true",
       "ktlint_standard_no-wildcard-imports" to "disabled",
       // ktlint does not break up long lines, it just fails on them
       "ktlint_standard_max-line-length" to "disabled",
@@ -68,4 +70,4 @@ spotless {
     trimTrailingWhitespace()
     endWithNewline()
   }
-}
+}

context/build.gradle.kts

@@ -71,4 +71,4 @@ tasks {
   check {
     dependsOn(testing.suites)
   }
-}
+}

exporters/common/build.gradle.kts

@@ -36,4 +36,4 @@ dependencies {
   testImplementation("com.google.api.grpc:proto-google-common-protos")
   testImplementation("io.grpc:grpc-testing")
   testRuntimeOnly("io.grpc:grpc-netty-shaded")
-}
+}

exporters/jaeger-proto/build.gradle.kts

@@ -22,4 +22,4 @@ tasks {
       compilerArgs.add("-Xlint:-serial")
     }
   }
-}
+}

exporters/jaeger-thrift/build.gradle.kts

@@ -25,4 +25,4 @@ dependencies {
   testImplementation("com.google.guava:guava-testlib")
 
   testImplementation(project(":sdk:testing"))
-}
+}

exporters/jaeger/build.gradle.kts

@@ -46,4 +46,4 @@ sourceSets {
   main {
     java.srcDir("$buildDir/generated/source/wire")
   }
-}
+}

exporters/logging-otlp/build.gradle.kts

@@ -25,4 +25,4 @@ dependencies {
   testImplementation(project(":sdk:trace"))
 
   testImplementation("org.skyscreamer:jsonassert")
-}
+}

exporters/logging/build.gradle.kts

@@ -17,4 +17,4 @@ dependencies {
 
   testImplementation(project(":sdk:testing"))
   testImplementation(project(":sdk:logs-testing"))
-}
+}

exporters/otlp/all/build.gradle.kts

@@ -80,4 +80,4 @@ tasks {
       },
     )
   }
-}
+}

exporters/otlp/common/build.gradle.kts

@@ -57,4 +57,4 @@ sourceSets {
   main {
     java.srcDir("$buildDir/generated/source/wire")
   }
-}
+}

exporters/otlp/logs/build.gradle.kts

@@ -62,4 +62,4 @@ tasks {
   named("check") {
     dependsOn(testing.suites)
   }
-}
+}

exporters/otlp/testing-internal/build.gradle.kts

@@ -30,4 +30,4 @@ dependencies {
   implementation("com.linecorp.armeria:armeria-junit5")
   implementation("io.github.netmikey.logunit:logunit-jul")
   implementation("org.assertj:assertj-core")
-}
+}

exporters/prometheus/build.gradle.kts

@@ -90,4 +90,4 @@ tasks {
       compilerArgs.add("--add-reads=io.opentelemetry.exporters.prometheus.test=org.junit.jupiter.api")
     }
   }
-}
+}

exporters/zipkin/build.gradle.kts

@@ -23,4 +23,4 @@ dependencies {
 
   testImplementation("com.linecorp.armeria:armeria")
   testImplementation("org.testcontainers:junit-jupiter")
-}
+}

extensions/incubator/build.gradle.kts

@@ -13,4 +13,4 @@ dependencies {
   api(project(":api:all"))
 
   testImplementation(project(":sdk:testing"))
-}
+}

extensions/kotlin/build.gradle.kts

@@ -59,4 +59,4 @@ tasks {
   check {
     dependsOn(testing.suites)
   }
-}
+}

extensions/kotlin/src/main/kotlin/io/opentelemetry/extension/kotlin/ContextExtensions.kt

@@ -34,4 +34,4 @@ fun CoroutineContext.getOpenTelemetryContext(): Context {
     return element.context
   }
   return Context.root()
-}
+}

extensions/kotlin/src/test/kotlin/io/opentelemetry/extension/kotlin/KotlinCoroutinesTest.kt

@@ -101,4 +101,4 @@ class KotlinCoroutinesTest {
       }
     }
   }
-}
+}

extensions/kotlin/src/testStrictContext/kotlin/io/opentelemetry/extension/kotlin/StrictContextWithCoroutinesTest.kt

@@ -149,4 +149,4 @@ class StrictContextWithCoroutinesTest {
       assertThat(Context.current().get(ANIMAL)).isEqualTo(animal)
     }
   }
-}
+}

extensions/trace-propagators/build.gradle.kts

@@ -16,4 +16,4 @@ dependencies {
 
   testImplementation("io.jaegertracing:jaeger-client")
   testImplementation("com.google.guava:guava")
-}
+}

integration-tests/build.gradle.kts

@@ -13,4 +13,4 @@ dependencies {
   testImplementation("com.linecorp.armeria:armeria-junit5")
   testImplementation("org.junit.jupiter:junit-jupiter-params")
   testImplementation("org.testcontainers:junit-jupiter")
-}
+}

integration-tests/graal/build.gradle.kts

@@ -26,4 +26,4 @@ graalvmNative {
     }
   }
   toolchainDetection.set(false)
-}
+}

integration-tests/otlp/build.gradle.kts

@@ -40,4 +40,4 @@ tasks {
   check {
     dependsOn(testing.suites)
   }
-}
+}

integration-tests/tracecontext/build.gradle.kts

@@ -30,4 +30,4 @@ tasks {
 
     jvmArgs("-Dio.opentelemetry.testArchive=${shadowJar.get().archiveFile.get().asFile.absolutePath}")
   }
-}
+}

opencensus-shim/build.gradle.kts

@@ -28,4 +28,4 @@ tasks.named<Test>("test") {
   // methods available.
   setForkEvery(1)
   maxParallelForks = 3
-}
+}

opentracing-shim/build.gradle.kts

@@ -24,4 +24,4 @@ tasks {
       showStandardStreams = true
     }
   }
-}
+}

perf-harness/build.gradle.kts

@@ -17,4 +17,4 @@ dependencies {
   implementation("org.testcontainers:junit-jupiter")
 
   runtimeOnly("io.grpc:grpc-netty-shaded")
-}
+}

sdk-extensions/autoconfigure-spi/build.gradle.kts

@@ -15,4 +15,4 @@ dependencies {
   // implementation dependency to require users to add the artifact directly to their build to use
   // SdkLoggerProviderBuilder.
   implementation(project(":sdk:logs"))
-}
+}

sdk-extensions/autoconfigure/build.gradle.kts

@@ -114,4 +114,4 @@ tasks {
   check {
     dependsOn(testing.suites)
   }
-}
+}

sdk-extensions/incubator/build.gradle.kts

@@ -30,4 +30,4 @@ dependencies {
   testImplementation(project(":sdk-extensions:autoconfigure"))
 
   testImplementation("com.google.guava:guava-testlib")
-}
+}

sdk-extensions/jaeger-remote-sampler/build.gradle.kts

@@ -82,4 +82,4 @@ tasks {
       compilerArgs.add("-Xlint:-serial")
     }
   }
-}
+}

sdk/all/build.gradle.kts

@@ -25,4 +25,4 @@ dependencies {
   testAnnotationProcessor("com.google.auto.value:auto-value")
 
   testImplementation(project(":sdk:testing"))
-}
+}

sdk/common/build.gradle.kts

@@ -79,4 +79,4 @@ tasks {
   check {
     dependsOn(testing.suites)
   }
-}
+}

sdk/logs-testing/build.gradle.kts

@@ -21,4 +21,4 @@ dependencies {
   testImplementation(project(":sdk:logs-testing"))
 
   testImplementation("junit:junit")
-}
+}

sdk/logs/build.gradle.kts

@@ -18,4 +18,4 @@ dependencies {
   testImplementation("org.awaitility:awaitility")
 
   annotationProcessor("com.google.auto.value:auto-value")
-}
+}

sdk/metrics-testing/build.gradle.kts

@@ -18,4 +18,4 @@ dependencies {
   annotationProcessor("com.google.auto.value:auto-value")
 
   testImplementation("junit:junit")
-}
+}

sdk/metrics/build.gradle.kts

@@ -54,4 +54,4 @@ tasks {
   check {
     dependsOn(testing.suites)
   }
-}
+}

sdk/testing/build.gradle.kts

@@ -20,4 +20,4 @@ dependencies {
 
   testImplementation("junit:junit")
   testImplementation("org.junit.vintage:junit-vintage-engine")
-}
+}