Skip to content

Project Feedback! #1

@codepathreview

Description

@codepathreview

👍 Excellent Job. A few notes after checking out the code:

  • Properly reused the single base method in search activity to fetch results for both initial load and the pagination
  • Nice to see you added the search box to the ActionBar!
  • Properly used spinners (with populated values) or checkboxes to allow users to select filters
  • Nice job adding the share intent to the article detail view!
  • Good to see you used a filters object to represent the filters to apply to the query
  • Nice to see you implement robust error handling, check if internet is available, handle error cases, network failures
  • Nice work setting up shared preferences to persist the settings between activities
  • Properly sent and received relevant filters using a bundle to pass data between activities
  • Consider trying out the RecyclerView, the successor to the ListView and GridView.
  • Try out the data binding support module to automatically bind data into activity layout templates.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us [email protected].

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions