Found a weird edge case, not worthy of a bug, make sure that package.json has a name attribute

[derekjwilliams]

I was updating an existing project from version 0.5.1 to 0.6.1 and I kept getting these errors on build:

The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Error("missing field `name`", line: 41, column: 1)
Location: crates/stylex-path-resolver/src/package_json/mod.rs:46

I was unable to reproduce this on a new project, it turns out that for some reason I did not have a name attribute in my project.json in my existing project. Added the missing line and that fixed it.

To see this on a very simple project, clone this repo:

[email protected]:derekjwilliams/stylex-rscompiler-example.git

Edit the package.json, removing this line:

  "name": "next-example",

then run npm build

[Dwlad90]

The field name is required in all package.json's because StyleX uses it when generating theme classes, such as hash of string "${packageName}:${package_dir}". I think it is necessary to add a clearer message in this case.

stylex-swc-plugin/crates/stylex-shared/src/shared/structures/state_manager.rs

Line 322 in 316d91f

return format!("{}:{}", package_name, package_dir);

[derekjwilliams]

I can take a look at small fixes like this in the future to help out, but I'll have to get up to speed, a little more than I have, with Rust.

[Dwlad90]

I opened #194 with an improved error message. In your opinion, will it be clearer what the essence of the problem is?

[derekjwilliams]

Looks great, thanks so much.

[wereHamster]

Can we have StyleX use an empty string (or some other fixed value) when name is not present in package.json?

[Dwlad90]

I see that this case is problematic to use, so I will make the "name" field optional as well

[Dwlad90]

PR #202 has been merged and will be available in release 0.6.2-rc.5