Update unit tests for all possible keyword inputs.

Author: joshuabmoore

pyspi/utils.py

@@ -158,6 +158,11 @@ def filter_spis(keywords, output_name=None, configfile=None):
         FileNotFoundError: If the specified `configfile` or the default `config.yaml` is not found.
         IOError: If there's an error reading the YAML file.
     """
+    # handle invalid keyword input
+    if not keywords:
+        raise ValueError("At least one keyword must be provided.")
+    if not all(isinstance(keyword, str) for keyword in keywords):
+        raise ValueError("All keywords must be strings.")
     if not isinstance(keywords, list):
         raise ValueError("Keywords must be provided as a list of strings.")
 

tests/test_utils.py

@@ -17,8 +17,16 @@ def mock_yaml_content():
 
 def test_filter_spis_invalid_keywords():
     """Pass in a dataype other than a list for the keywords"""
-    with pytest.raises(ValueError) as e:
+    with pytest.raises(ValueError) as excinfo:
         filter_spis(keywords="linear", configfile="pyspi/config.yaml")
+    assert "Keywords must be provided as a list of strings" in str(excinfo.value)
+    # check for passing in an empty list
+    with pytest.raises(ValueError) as excinfo:
+        filter_spis(keywords=[], configfile="pyspi/config.yaml")
+    assert "At least one keyword must be provided" in str(excinfo.value)
+    with pytest.raises(ValueError) as excinfo:
+        filter_spis(keywords=[4], configfile="pyspi/config.yaml")
+    assert "All keywords must be strings" in str(excinfo.value)  
 
 def test_filter_spis_with_invalid_config():
     """Pass in an invalid/missing config file"""