Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3 development diagnostics defined with wrong size? #6599

Open
quantheory opened this issue Sep 9, 2024 · 0 comments
Open

P3 development diagnostics defined with wrong size? #6599

quantheory opened this issue Sep 9, 2024 · 0 comments

Comments

@quantheory
Copy link
Contributor

In the P3 interface for EAM, we have two lines that define the P3 main routine "input" and "output" sizes for diagnostic fields in the history buffer, but then the actual arrays don't have the expected sizes (17 and 31 rather than 16 and 32). As a result, I think that one of the inputs (relvar) is simply not output, while one of the output fields is not set at all (so potentially garbage data is being written to the file, or maybe reading off the end of the array causes undefined behavior if this field was actually output).

I'm not sure if anyone actually uses these diagnostics right now, so it's probably not the highest priority to fix, but if these outputs are being retained, this should probably be fixed so that they have the correct values!

The SCREAMv0 version of P3 also has the same problem, but I haven't had time to check the EAMxx code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants