You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the P3 interface for EAM, we have two lines that define the P3 main routine "input" and "output" sizes for diagnostic fields in the history buffer, but then the actual arrays don't have the expected sizes (17 and 31 rather than 16 and 32). As a result, I think that one of the inputs (relvar) is simply not output, while one of the output fields is not set at all (so potentially garbage data is being written to the file, or maybe reading off the end of the array causes undefined behavior if this field was actually output).
I'm not sure if anyone actually uses these diagnostics right now, so it's probably not the highest priority to fix, but if these outputs are being retained, this should probably be fixed so that they have the correct values!
The SCREAMv0 version of P3 also has the same problem, but I haven't had time to check the EAMxx code.
The text was updated successfully, but these errors were encountered:
In the P3 interface for EAM, we have two lines that define the P3 main routine "input" and "output" sizes for diagnostic fields in the history buffer, but then the actual arrays don't have the expected sizes (17 and 31 rather than 16 and 32). As a result, I think that one of the inputs (
relvar
) is simply not output, while one of the output fields is not set at all (so potentially garbage data is being written to the file, or maybe reading off the end of the array causes undefined behavior if this field was actually output).I'm not sure if anyone actually uses these diagnostics right now, so it's probably not the highest priority to fix, but if these outputs are being retained, this should probably be fixed so that they have the correct values!
The SCREAMv0 version of P3 also has the same problem, but I haven't had time to check the EAMxx code.
The text was updated successfully, but these errors were encountered: