Skip to content

Commit c346d34

Browse files
authored
fix: icon and color fix for merged session (#176)
1 parent 7d62c5f commit c346d34

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

src/components/session/Review.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const reviewSessionHandle = async () => {
5252
const loader = useLoader().show();
5353
snackbar.value = await reviewBySessionNumber(
5454
reviewSession.value.number,
55-
reviewSession.value.node_id,
55+
reviewSession.value.id,
5656
);
5757
reviewSession.value = false;
5858
loader.hide();

src/helpers/get-pr-status.js

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,18 @@ export default function getPrStatus(session) {
99
icon = "git-pull-request-draft";
1010
state = "draft";
1111
}
12+
} else if (
13+
session.state === "merged" ||
14+
session.merged_at ||
15+
session.pull_request?.merged_at
16+
) {
17+
color = "violet";
18+
icon = "git-merge";
19+
state = "merged";
1220
} else {
13-
if (session.merged_at || session.pull_request?.merged_at) {
14-
color = "violet";
15-
icon = "git-merge";
16-
state = "merged";
17-
} else {
18-
color = "red";
19-
icon = "git-pull-request-closed";
20-
state = "closed";
21-
}
21+
color = "red";
22+
icon = "git-pull-request-closed";
23+
state = "closed";
2224
}
2325

2426
return {

0 commit comments

Comments
 (0)