Skip to content

Conversation

@Akkadius
Copy link
Contributor

Description

This is a performance adjustment for World where 3k players and 1,800 zoneservers showed strain on World. A grand majority of the CPU load (98%) this was shown to be TCP chatter (server to server).

I ran S<->S packet logging in world and found the following data. This change will be one of several found from these results. https://gist.github.com/Akkadius/12b57fadbbe21ea9a46b854c62cc3a65#file-world-s2s-1m-md

For this PR - this targets the following packets and should reduce chatter by upwards of 100% in the case that most players are not in adventures in most servers.

  • ServerOP_AdventureDataRequest (361 packets in a minute - 6 packets/s received from zones)
  • ServerOP_AdventureZoneData (41 packets a minute - 7 packets/s received from zones)

Type of change

  • Optimization

Testing

Loaded into a zone, no query errors, no packet sent

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius changed the title [Performance] Reduce Adventure S2S chatter [Performance] Reduce Adventure S2S Chatter to World Mar 22, 2025
@Akkadius Akkadius merged commit bc1ffe0 into master Mar 29, 2025
2 checks passed
@Akkadius Akkadius deleted the akkadius/optimize-adventure-s2s branch March 29, 2025 19:48
This was referenced Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants