Delete environment option in environment list

[srinijammula]

Users cannot currently delete expired or unused environments directly through the UI. Add a delete option in the environment list table.

[gokulprathin8]

LLM reponse:

I can add a delete option to the environment list table. This involves changes on both the frontend (JavaScript and potentially HTML structure if needed) and the backend (Java controller and service/tool).

Here are the necessary changes file-wise:

1. Backend: Add Environment Deletion Logic

• File: src/main/java/com/gw/tools/EnvironmentTool.java

  • Add a method to handle the deletion using the repository.

  --- a/src/main/java/com/gw/tools/EnvironmentTool.java
  +++ b/src/main/java/com/gw/tools/EnvironmentTool.java
  @@ -21,6 +21,8 @@
  
     @Autowired BaseTool bt;
  
  +  Logger logger = LoggerFactory.getLogger(getClass());
  +
     // @Autowired
     // LocalhostTool lt;
  
  @@ -248,4 +250,20 @@
  
     return resp;
   }
  +
  +  /**
  +   * Delete environment by id
  +   * @param envId Environment ID
  +   * @return status message
  +   */
  +  public String del(String envId) {
  +    try {
  +      envrep.deleteById(envId);
  +      return "{\"status\":\"success\"}";
  +    } catch (Exception e) {
  +      logger.error("Failed to delete environment " + envId, e);
  +      return "{\"status\":\"failed\", \"reason\":\"" + e.getMessage() + "\"}";
  +    }
  +  }
   }

• File: src/main/java/com/gw/web/GeoweaverController.java

  • Modify the /del endpoint to handle the "environment" type.

  --- a/src/main/java/com/gw/web/GeoweaverController.java
  +++ b/src/main/java/com/gw/web/GeoweaverController.java
  @@ -138,6 +138,9 @@
       case "history":
         resp = hist.deleteById(id);
         break;
  +    case "environment":
  +      resp = et.del(id); // Use EnvironmentTool to delete
  +      break;
       case "clear_nodes_edges":
         assert id != null;
         Optional<Workflow> optionalWorkflow = workflowrepository.findById(id);
  

2. Frontend: Add Delete Button and Functionality

• File: src/main/resources/static/js/gw.host.js

  • Modify showEnvironmentTable to add a new "Action" column and a delete button for each row.
  • Add a new function deleteEnvironment to handle the AJAX call for deletion.

  --- a/src/main/resources/static/js/gw.host.js
  +++ b/src/main/resources/static/js/gw.host.js
  @@ -450,6 +450,7 @@
     '      <th scope="col">PyEnv</th> ' +
     '      <th scope="col">Base Directory</th> ' +
     '      <th scope="col">Settings</th> ' +
  +  '      <th scope="col">Action</th> ' +
     "    </tr> " +
     "  </thead> " +
     "  <tbody> ";
  @@ -457,7 +458,7 @@
   for (var i = 0; i < msg.length; i++) {
     content +=
       "    <tr> " +
  -    "      <td>" +
  +    "      <td id=\"env-row-" + msg[i].id + "\">" + // Add unique ID to the row for easy removal
       msg[i].name +
       "</td> " +
       "      <td>" +
  @@ -470,6 +471,8 @@
       "      <td>" +
       msg[i].settings +
       "</td> " +
  +    "      <td><button class=\"btn btn-danger btn-sm\" onclick=\"GW.host.deleteEnvironment('" + msg[i].id + "')\"> " +
  +    "          <i class=\"fa fa-trash\"></i> Delete</button></td>" +
       "    </tr>";
   }
  
  @@ -550,4 +553,31 @@
  
   GW.general.switchTab("host");

},
+
+ deleteEnvironment: function(envId) {
+ if (confirm("Are you sure you want to delete this environment? This action cannot be undone.")) {
+ $.ajax({
+ url: "del",
+ method: "POST",
+ data: { type: "environment", id: envId }
+ }).done(function(response) {
+ try {
+ let resp = GW.general.parseResponse(response);
+ if (resp.status === "success" || response === "done") { // Check both potential success responses
+ $("#env-row-" + envId).closest('tr').remove(); // Find the closest tr and remove it
+ GW.general.showToasts("Environment deleted successfully.");
+ } else {
+ alert("Failed to delete environment: " + (resp.reason || "Unknown error"));
+ }
+ } catch (e) {
+ console.error("Error parsing delete response:", e);
+ alert("Failed to delete environment due to response parsing error.");
+ }
+ }).fail(function(jqXHR, textStatus, errorThrown) {
+ console.error("Failed to delete environment:", textStatus, errorThrown);
+ alert("Failed to delete environment. Status: " + textStatus);
+ });
+ }
+},
+
};

```

Explanation of Changes:

1. Backend (EnvironmentTool.java):
   • A new public method del(String envId) is added.
   • It calls envrep.deleteById(envId) to remove the environment from the database.
   • It includes basic error handling and returns a JSON status message.
2. Backend (GeoweaverController.java):
   • The existing /del endpoint is modified.
   • A new else if condition checks if the type parameter is "environment".
   • If it is, it calls the newly added et.del(id) method.
3. Frontend (gw.host.js):
   • In showEnvironmentTable:
     • An "Action" column header (<th>) is added to the table structure.
     • A unique ID (env-row-${msg[i].id}) is added to each table row (<tr>) to make it easy to target for removal.
     • A new table data cell (<td>) is added to each row.
     • Inside the new cell, a "Delete" button is created with an onclick event that calls GW.host.deleteEnvironment and passes the specific environment's ID (msg[i].id).
   • A new function deleteEnvironment(envId) is created:
     • It first asks the user for confirmation using confirm().
     • If confirmed, it sends an AJAX POST request to the /del endpoint, passing type=environment and the id of the environment to be deleted.
     • The .done() handler parses the response. If the deletion was successful on the backend, it removes the corresponding table row from the UI using jQuery's remove() method and shows a success toast.
     • The .fail() handler shows an alert if the AJAX request fails.

Now, when you view the environments for a host, you should see a "Delete" button next to each entry. Clicking it will prompt for confirmation and then remove the environment from the database and the displayed table.