Fix warnings and remove unused code

Author: Ghabry

lcftrans/src/main.cpp

@@ -249,6 +249,8 @@ void DumpLdb(const std::string& filename) {
 }
 
 void DumpLmuLmtInner(const std::string& filename, Translation& t, const std::string& poname) {
+	(void)filename;
+
 	Translation pot;
 
 	if (t.getEntries().empty()) {

lcftrans/src/translation.cpp

@@ -356,6 +356,7 @@ static void parseEvents(Translation& t, Root& root, const F& make_info) {
 	ParseEvent<decltype(make_info)> p { t, make_info };
 
 	lcf::rpg::ForEachString(root, [&](const auto& val, const auto& ctx) {
+		(void)val;
 		if (!ctx.parent ||
 				!std::is_same<decltype(ctx.parent->obj), std::add_pointer_t<ParentType>>::value ||
 				!isEventCommandString(ctx)) {
@@ -524,7 +525,7 @@ Translation Translation::fromPO(const std::string& filename) {
 	};
 
 	auto extract_string = [&](int offset) -> std::string {
-		if (offset >= line_view.size()) {
+		if (offset >= static_cast<int>(line_view.size())) {
 			std::cerr << "Parse error (Line " << line_number << ") is empty\n";
 			return "";
 		}

lcfviz/src/main.cpp

@@ -13,7 +13,6 @@
 #include <fstream>
 #include <functional>
 #include <iostream>
-#include <unordered_map>
 #include <argparse.hpp>
 #include <lcf/encoder.h>
 #include <lcf/reader_util.h>
@@ -42,25 +41,6 @@ Creates an overlap-free, directed graph (for huge graphs use sfdp, not dot)
 
 )" "Homepage " PACKAGE_URL " - Report bugs at: " PACKAGE_BUGREPORT;
 
-static int print_help(char** argv) {
-	std::cerr << "lcfviz - Creates a dot file from a map tree by scanning the map for teleports.\n";
-	std::cerr << "Usage: " << argv[0] << " [OPTION...] DIRECTORY [ENCODING]\n";
-	std::cerr << "Options:\n";
-	std::cerr << "  -d, --depth DEPTH  Maximal depth from the start node (default: no limit)\n";
-	std::cerr << "                     Enables unreachable node detection (-r)\n";
-	std::cerr << "  -h, --help         This usage message\n";
-	std::cerr << "  -o, --output FILE  Output file (default: stdout)\n";
-	std::cerr << "  -r, --remove       Remove nodes that are unreachable from the start node\n";
-	std::cerr << "  -s, --start ID     Initial node of the graph (default: start party position)\n";
-	std::cerr << "\n";
-	std::cerr << "When not specified the encoding is read from RPG_RT.ini or auto-detected.\n";
-	std::cerr << "\n";
-	std::cerr << "Example usage:\n";
-	std::cerr << " lcfviz YOURGAME | dot -Goverlap=false -Gsplines=true -Tpng -o graph.png\n";
-	std::cerr << "Creates an overlap-free, directed graph (for huge graphs use sfdp, not dot)\n";
-	return 2;
-}
-
 namespace {
 	/* config */
 	std::string encoding, indir;
@@ -380,6 +360,7 @@ void ParseLmt(const std::string& filename) {
 	}
 
 	lcf::rpg::ForEachString(*tree, [&](const auto& val, const auto& ctx) {
+		(void)val;
 		if (ctx.name == "name") {
 			parse_map(ctx);
 		}

lmu2png/src/main.cpp

@@ -237,7 +237,7 @@ static BitmapPtr process(L2IConfig conf, ErrorCallbackFunc error_cb, ErrorCallba
 	return output_img;
 }
 
-static void cliErrorCallback(const std::string& error, ErrorCallbackParam param) {
+static void cliErrorCallback(const std::string& error, ErrorCallbackParam) {
 	// Simply tell about the error
 	std::cerr << error << "\n";
 }

lmu2png/src/utils.cpp

@@ -49,8 +49,8 @@ bool Exists(const std::string& filename) {
 void CollectResourcePaths(std::string& main_path) {
 	auto split_path = [](std::string path) {
 		int start = 0;
-		for (int i = 0; i <= path.size(); i++) {
-			if (path[i] == ';' || path[i] == ':' || i == path.size()) {
+		for (int i = 0; i <= static_cast<int>(path.size()); i++) {
+			if (path[i] == ';' || path[i] == ':' || i == static_cast<int>(path.size())) {
 				std::string temp;
 				temp.append(path, start, i - start);
 				resource_dirs.emplace_back(temp);

png2xyz/src/png2xyz.cpp

@@ -207,7 +207,7 @@ int main(int argc, char* argv[]) {
 		memset(xyz_data, 0, 768);
 
 		// Create XYZ palette
-		for (size_t i = 0; i < num_palette; i++) {
+		for (int i = 0; i < num_palette; i++) {
 			xyz_data[i * 3] = palette[i].red;
 			xyz_data[i * 3 + 1] = palette[i].green;
 			xyz_data[i * 3 + 2] = palette[i].blue;