-
-
Notifications
You must be signed in to change notification settings - Fork 310
Add Angular 20 to package.json #2360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 36ee0c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for Angular v20 in the package’s peer dependencies.
- Extends
@angular/core
peer range to include^20.0.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add angular 20 in GitHub Actions configuration, so that our tests are ran against angular 20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Angular 20 throughout the repository.
- Bumps peerDependencies to
@angular/core
^18.0.0, ^19.0.0, ^20.0.0 and drops Angular 17 - Expands CI matrix to test Angular 18-20 against Node 18, 20, 22, 24 with appropriate exclusions
- Enhances the E2E prep script to fall back to
app.ts
ifapp.component.ts
is missing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
scripts/prepare-e2e.js | Add fallback path detection for app.ts in the E2E setup script |
packages/apollo-angular/package.json | Include Angular 20 and remove Angular 17 from peerDependencies |
.github/workflows/main.yml | Update workflow matrix for Angular 20 and additional Node versions |
.changeset/yellow-points-sort.md | New changeset entry: support Angular 20 |
.changeset/lazy-plants-poke.md | New changeset entry: drop support for Angular 17 |
Comments suppressed due to low confidence (1)
scripts/prepare-e2e.js:10
- The new fallback logic for
app.ts
isn't covered by existing tests. Add a unit or integration test case whereapp.component.ts
is absent to ensureapp.ts
is selected.
let filepath =
[ | ||
path.join(cwd, `./${name}/src/app/app.component.ts`), | ||
path.join(cwd, `./${name}/src/app/app.ts`), | ||
].find(path => fs.existsSync(path)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The callback parameter path
shadows the imported path
module. Consider renaming the parameter (e.g., p
or candidatePath
) to avoid confusion.
].find(path => fs.existsSync(path)); | |
].find(candidatePath => fs.existsSync(candidatePath)); |
Copilot uses AI. Check for mistakes.
@@ -0,0 +1,5 @@ | |||
--- | |||
'apollo-angular': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two separate major changeset files for apollo-angular
. Merge these into a single changeset to prevent multiple major bumps in one release.
Copilot uses AI. Check for mistakes.
'apollo-angular': major | ||
--- | ||
|
||
Drop support for Angular 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset also declares a major bump. Consolidate with the other changeset so both Angular 20 support and Angular 17 drop are released together.
Drop support for Angular 17 | |
Drop support for Angular 17 and add support for Angular 20 |
Copilot uses AI. Check for mistakes.
Resolves: #2359
Checklist:
was reached (not necessary for small changes)