Skip to content

Add Angular 20 to package.json #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 30, 2025
Merged

Conversation

mark7-bell
Copy link
Contributor

@mark7-bell mark7-bell commented May 29, 2025

Resolves: #2359

Checklist:

  • If this PR is a new feature, please reference a discussion where a consensus about the design
    was reached (not necessary for small changes)
  • Make sure all the significant new logic is covered by tests

Copy link

changeset-bot bot commented May 29, 2025

🦋 Changeset detected

Latest commit: 36ee0c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
apollo-angular Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for Angular v20 in the package’s peer dependencies.

  • Extends @angular/core peer range to include ^20.0.0.

Copy link
Owner

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add angular 20 in GitHub Actions configuration, so that our tests are ran against angular 20.

@PowerKiKi PowerKiKi enabled auto-merge (rebase) May 30, 2025 08:13
@PowerKiKi PowerKiKi requested a review from Copilot May 30, 2025 08:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Angular 20 throughout the repository.

  • Bumps peerDependencies to @angular/core ^18.0.0, ^19.0.0, ^20.0.0 and drops Angular 17
  • Expands CI matrix to test Angular 18-20 against Node 18, 20, 22, 24 with appropriate exclusions
  • Enhances the E2E prep script to fall back to app.ts if app.component.ts is missing

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/prepare-e2e.js Add fallback path detection for app.ts in the E2E setup script
packages/apollo-angular/package.json Include Angular 20 and remove Angular 17 from peerDependencies
.github/workflows/main.yml Update workflow matrix for Angular 20 and additional Node versions
.changeset/yellow-points-sort.md New changeset entry: support Angular 20
.changeset/lazy-plants-poke.md New changeset entry: drop support for Angular 17
Comments suppressed due to low confidence (1)

scripts/prepare-e2e.js:10

  • The new fallback logic for app.ts isn't covered by existing tests. Add a unit or integration test case where app.component.ts is absent to ensure app.ts is selected.
let filepath =

[
path.join(cwd, `./${name}/src/app/app.component.ts`),
path.join(cwd, `./${name}/src/app/app.ts`),
].find(path => fs.existsSync(path));
Copy link
Preview

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback parameter path shadows the imported path module. Consider renaming the parameter (e.g., p or candidatePath) to avoid confusion.

Suggested change
].find(path => fs.existsSync(path));
].find(candidatePath => fs.existsSync(candidatePath));

Copilot uses AI. Check for mistakes.

@@ -0,0 +1,5 @@
---
'apollo-angular': major
Copy link
Preview

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two separate major changeset files for apollo-angular. Merge these into a single changeset to prevent multiple major bumps in one release.

Copilot uses AI. Check for mistakes.

'apollo-angular': major
---

Drop support for Angular 17
Copy link
Preview

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset also declares a major bump. Consolidate with the other changeset so both Angular 20 support and Angular 17 drop are released together.

Suggested change
Drop support for Angular 17
Drop support for Angular 17 and add support for Angular 20

Copilot uses AI. Check for mistakes.

@PowerKiKi PowerKiKi merged commit f311133 into PowerKiKi:master May 30, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add Angular 20 support
2 participants