Jon/fix/zano private view key await #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Jon-edge merged 2 commits into master from jon/fix/zano-private-view-key-await

Jul 18, 2025

Contributor

Jon-edge commented Jul 14, 2025 •

edited

Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Description

none

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1210733162536432
- https://app.asana.com/0/0/1210793361845821

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from 44660e4 to bee0726 Compare

July 17, 2025 05:29

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from bee0726 to b362e3a Compare

July 17, 2025 05:38

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from b362e3a to cf54a4b Compare

July 17, 2025 05:46

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from cf54a4b to 50303fb Compare

July 17, 2025 06:04

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from 50303fb to a81130c Compare

July 17, 2025 06:15

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from a81130c to 74463fa Compare

July 17, 2025 06:23

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from 74463fa to ff0324c Compare

July 17, 2025 17:13

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch 2 times, most recently from 711ef0d to 05880a9 Compare

July 17, 2025 17:29

This comment was marked as outdated.

Sign in to view

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from 05880a9 to db795b7 Compare

July 17, 2025 18:07

swansontec reviewed

View reviewed changes

Contributor

swansontec left a comment

I'll go ahead and rebase this branch with my own fixes, rather than leaving a more-detailed review. I know you are swamped with other tasks.

src/zano/ZanoEngine.ts Outdated Show resolved Hide resolved

test/utils/lifecycleManager.test.ts Outdated Show resolved Hide resolved

test/utils/lifecycleManager.test.ts Outdated Show resolved Hide resolved

test/utils/lifecycleManager.test.ts Outdated Show resolved Hide resolved

src/common/lifecycleManager.ts Outdated Show resolved Hide resolved

src/zano/ZanoEngine.ts Outdated Show resolved Hide resolved

swansontec force-pushed the jon/fix/zano-private-view-key-await branch 2 times, most recently from 24e5eb8 to 62f3924 Compare

July 17, 2025 22:57

This comment was marked as outdated.

Sign in to view

Contributor

swansontec commented Jul 17, 2025

Bug: Initialization Deadlock and Error Handling Issue

A deadlock occurs in the syncNetwork method during wallet initialization.

This deadlock doesn't actually occur, since many methods can trigger the initial onStart, but there can be a slight unnecessary delay in some cases. Added a fixup to address the delay.

This comment was marked as outdated.

Sign in to view

Contributor

swansontec commented Jul 17, 2025

Bug: Optional Chaining Removed Causing Errors

The optional chaining operator was removed from opts?.privateKeys to opts.privateKeys in the syncNetwork method.

Not a bug. The contract with the core says the keys will be present. Otherwise, it is a genuine error.

Jon-edge added 2 commits

July 17, 2025 17:34


          Add LifecycleManager utility for resource lifecycle management

7b51aa7

- Manages resources that need to start/stop at random times
- Prevents multiple instances running simultaneously
- Handles state transitions: stopped → starting → started → stopping
- Provides error handling and cleanup on failures
- Generic utility that could be useful for other engines


          Improve Zano wallet initialization using LifecycleManager

aa589cf

- Replace direct zanoWalletId tracking with LifecycleManager pattern
- Add ALREADY_EXISTS error handling for wallet reinitialization
- Fix getDisplayPublicSeed to wait for wallet initialization
- Improve error logging and recovery for existing wallets
- Use getOpenedWallets() to find existing wallet by storage path

Jon-edge force-pushed the jon/fix/zano-private-view-key-await branch from 95428c0 to aa589cf Compare

July 18, 2025 00:35

Jon-edge enabled auto-merge

July 18, 2025 00:37

Jon-edge requested a review from swansontec

July 18, 2025 01:07

swansontec approved these changes

View reviewed changes

Jon-edge merged commit cf3a216 into master

3 checks passed

Jon-edge deleted the jon/fix/zano-private-view-key-await branch

July 18, 2025 17:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet