Fix mirroring between accountReferral's installerId and `accountA…

[Jon-edge]

Fix mirroring between accountReferral's installerId and accountAppleAdsAttribution

Also rename the reported value to start fresh

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1211458036253303

---

Note

Restricts Apple Ads attribution to iOS with success/fail tracking, renames the analytics field, simplifies attribution fetching to return undefined when unavailable, and updates the changelog.

• Analytics & Attribution:
  • iOS-only seeding of accountAppleAdsAttribution in createAccountReferral with AAA_Success/AAA_Failed events (AccountReferralActions.ts).
  • Remove mirroring logic on load for accountAppleAdsAttribution.
  • Rename analytics param from refAccountAppleAdsAttribution to accountAppleAdsAttribution (tracking.ts).
  • Add new tracking events: AAA_Success, AAA_Failed.
• Attribution Fetching:
  • getAppleAdsAttribution now returns undefined on non‑iOS or failures; adjusts retry/error handling (FirstOpenActions.tsx).
• Changelog:
  • Add fix entry noting mirroring logic between installerId and accountAppleAdsAttribution.

^{Written by Cursor Bugbot for commit 21b5340. This will update automatically on new commits. Configure here.}

[chatgpt-codex-connector]

💡 Codex Review

edge-react-gui/src/actions/AccountReferralActions.ts

Lines 40 to 66 in b51d5db

	// First try the disk:
	try {
	if (account?.disklet?.setText == null) return
	if (account?.localDisklet?.setText == null) return
	const [cacheText, referralText] = await Promise.all([
	// Cache errors are fine:
	account.localDisklet.getText(REFERRAL_CACHE_FILE).catch(() => '{}'),
	// Referral errors mean we aren't affiliated:
	account.disklet.getText(ACCOUNT_REFERRAL_FILE)
	])
	const cache = asDiskReferralCache(JSON.parse(cacheText))
	const referral = unpackAccountReferral(JSON.parse(referralText))
	// Reference info server promo data to see if:
	// 1. Any of these `activePromotions` are no longer valid (e.g. a
	// promotion expired)
	// 2. If the current `installerId` should get copied into
	// `activePromotions` due to new matching promotion info
	referral.activePromotions = await getActivePromoIds({
	promoIds: referral.activePromotions,
	installerId: referral.installerId,
	countryCode: getState().ui.countryCode
	})
	dispatch({ type: 'ACCOUNT_REFERRAL_LOADED', data: { cache, referral } })
	await saveAccountReferral(getState())

[P1] Losing late Apple Ads attribution for existing accounts

Removing the getFirstOpenInfo fallback means loadAccountReferral no longer repopulates accountAppleAdsAttribution when it is missing. Apple Search Ads attribution often becomes available hours or days after install, so accounts created before the data exists will now persist with accountAppleAdsAttribution undefined even if the device later obtains valid attribution. Because logEvent now reports the account-level field, analytics for those users will stay empty and the installerId/attribution pair will never be mirrored. Consider keeping the fallback or scheduling a refresh so late-arriving attribution is stored on the account.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

• @codex fix this CI failure
• @codex address that feedback

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

• @codex fix this CI failure
• @codex address that feedback

[chatgpt-codex-connector]

[P1] Losing late Apple Ads attribution for existing accounts

Removing the getFirstOpenInfo fallback means loadAccountReferral no longer repopulates accountAppleAdsAttribution when it is missing. Apple Search Ads attribution often becomes available hours or days after install, so accounts created before the data exists will now persist with accountAppleAdsAttribution undefined even if the device later obtains valid attribution. Because logEvent now reports the account-level field, analytics for those users will stay empty and the installerId/attribution pair will never be mirrored. Consider keeping the fallback or scheduling a refresh so late-arriving attribution is stored on the account.

Useful? React with 👍 / 👎.

[Jon-edge]

We will just have to live with it not working if the value doesn't make it in after the retries in loadAccountReferral

The whole point is to make sure we are guaranteeing only new accounts have the attribution. If we really need to later we can add a "attributionFailed" flag or something.

Added reporting to compensate