Skip to content

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Oct 2, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Submitting an empty memo now clears the selected memo (and legacy unique identifier) in SendScene2.

  • SendScene2:
    • Allow empty memo submission to clear the corresponding spendInfo.memos entry; if legacy, also clear spendTarget.memo and spendTarget.uniqueIdentifier.
    • Update memo validation to accept empty input (skips error check) and refine types/handlers.
  • Changelog: Add entry noting the ability to clear memo values via empty input.

Written by Cursor Bugbot for commit 8c92e28. This will update automatically on new commits. Configure here.


cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional change.

@Jon-edge Jon-edge force-pushed the jon/memo-clearing branch 2 times, most recently from b89d50d to 2ca37db Compare October 3, 2025 23:42
cursor[bot]

This comment was marked as outdated.

@Jon-edge
Copy link
Collaborator Author

Jon-edge commented Oct 3, 2025

Trying to deal with the optional change kept giving new bugbot complaints. Just merging as-is for now.

If we revisit this area of code I'm sure we'll see the bugbot comment again.

@Jon-edge Jon-edge enabled auto-merge October 3, 2025 23:50
@Jon-edge Jon-edge disabled auto-merge October 3, 2025 23:53
@Jon-edge Jon-edge merged commit ed724f1 into develop Oct 3, 2025
3 checks passed
@Jon-edge Jon-edge deleted the jon/memo-clearing branch October 3, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants