Skip to content

Conversation

@samholmes
Copy link
Contributor

@samholmes samholmes commented Oct 28, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Enable tab-aware layout for bank routing details, remove notifications in KYC form, clarify hasNotifications prop default, and tweak ESLint config.

  • Scenes:
    • src/components/scenes/RampBankRoutingDetailsScene.tsx: Use SceneWrapper with hasTabs to account for tab bar insets.
    • src/components/scenes/RampKycFormScene.tsx: Remove hasNotifications from SceneWrapper; keep scroll/hasTabs/avoidKeyboard.
  • Common:
    • src/components/common/SceneWrapper.tsx: Clarify comment for hasNotifications prop (default false).
  • Tooling:
    • eslint.config.mjs: Remove src/components/common/SceneWrapper.tsx from the TypeScript warnings files list.

Written by Cursor Bugbot for commit 40b1a5d. This will update automatically on new commits. Configure here.


@Jon-edge
Copy link
Collaborator

Did you audit all scenes to ensure such a sweeping change causes no regression in notification behavior?

FWIW I do agree the default should be false, but we need visibility into the expected changes.

@samholmes
Copy link
Contributor Author

@Jon-edge I've audited the two scenes that were impacted.

@samholmes samholmes force-pushed the sam/security-check-infinite branch from 7cd349a to c5a6385 Compare October 28, 2025 22:45
@samholmes samholmes force-pushed the sam/security-check-infinite branch from c5a6385 to 40b1a5d Compare October 28, 2025 23:12
@samholmes samholmes enabled auto-merge October 28, 2025 23:12
@samholmes samholmes merged commit 0652c9f into develop Oct 29, 2025
3 checks passed
@samholmes samholmes deleted the sam/security-check-infinite branch October 29, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants