Paul/optimize anims #5871
Merged
Paul/optimize anims #5871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| </Fade> | ||
| <EdgeAnim | ||
| style={styles.bottomButton} | ||
| enter={{ type: 'fadeIn', delay: 300 }} |
There was a problem hiding this comment.
Bug: Wrong animation property causes delayed button appearance
The EdgeAnim component uses delay: 300 but the original Fade component used duration={300}. These have different semantics: delay waits before starting the animation while duration controls how long the animation takes. This causes the Next button to wait 300ms before starting to fade in, then animate for the default 300ms, taking 600ms total instead of the original 300ms. The equivalent scene SweepPrivateKeySelectCryptoScene correctly uses duration: 300.
These anims are barely visible and incur heavy cost in an additional view per row.
paullinator
force-pushed
the
paul/optimizeAnims
branch
2 times, most recently
from
702e6ec to
7d36ca4
Compare
Jon-edge
approved these changes
Dec 9, 2025
Member
Author
|
/rebase |
github-actions
bot
force-pushed
the
paul/optimizeAnims
branch
from
7d36ca4 to
4c94596
Compare
Use EdgeAnim instead We lose noFadeIn prop but the animation looks fine without it.
Useless to memoize since EdgeAnim always takes children which means it's props always change.
paullinator
force-pushed
the
paul/optimizeAnims
branch
from
4c94596 to
7f811af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Replaces Fade with EdgeAnim across the app, removes list-item enter animations for performance, refactors EdgeAnim, updates types/tests, and adjusts ESLint config.
themed/Fadewithcommon/EdgeAniminConfirmContinueModal,EdgeLoginScene,MigrateWalletSelectCryptoScene,SweepPrivateKeySelectCryptoScene.themed/Fade.tsxandhooks/animations/useFadeAnimation.ts.common/EdgeAnim.tsx: export component directly, add explicit types, adjust disable logic.TransactionListSceneandthemed/WalletListSwipeable.React.FCannotations, strictercatch (unknown)handling, and minor guards.eslint.config.mjsfile lists to drop removed/relocated entries.EdgeLoginScenesnapshot to match new animation/layout.Written by Cursor Bugbot for commit 4c94596. This will update automatically on new commits. Configure here.