Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.5.0 Cross Market Order #26

Merged
merged 43 commits into from
Nov 13, 2020
Merged

v2.5.0 Cross Market Order #26

merged 43 commits into from
Nov 13, 2020

Conversation

Effanuel
Copy link
Owner

@Effanuel Effanuel commented Nov 13, 2020 •
edited
Loading

New features:

  • Ability to add a cross order;
    • if you set a sell cross price below current price, it will trigger a market sell order as soon as the price crosses your cross order price;
    • if you set a buy cross price above current price, it will trigger a market buy order as soon as the price crosses your cross order price;
    • if you set a sell cross order price above current price, it will trigger a market sell order when the current price crosses up and then down of the set cross price;
    • if you set a buy cross order price below current price, it will trigger a market buy order when the current price crosses down and then up of the set cross price;

Bugs:

  • Adjusted ETH spread, since BitMEX updated it. (maybe need to create a script that would check for updates)

imagine if someone had to review this...

Effanuel and others added 30 commits September 15, 2020 00:17
@Effanuel
Added component tests (#22)
92887ce 
* Added component tests

* Updated the way async thunks are handled

* Renaming file

* Updated toast handling

* Misc

* Added component tests and drivers

* Added mock data

* Renaming files

* Misc changes

* Fixing AppState type

* Added mock redux store

* Updated packages

* Removed unused setuptests

* Fixed wrong import

* Cleanups
Added cross order container
c5f805a
Added reducer for corss order
0c48c19
Added button label presenter
fa9f7e2
Added some selectors for cross
72337ed
Moved presenter files
92b2c22
Renaming selectors
7e48a2c
Package lock update
4e4a87c
Updated button variant prop
9de82b8
Moved flush promises to a helper file
33b5748
Type fixes
ead1958
Misc
87e1532
Trying to improve performance on cross order
68d83ec
Wrapping with useCallback
8d2aed1
Moved usage of hooks in components to separate files
7662f88
Updating some types
8b2a263
Fixed wrong button variants
5412eba
Set containers to greyscale when not connected to websocket
d6591d5
Use func to simplify
b57bb36
Fixed jest setup file
e02be63
Fixed broken trailing order
e36dd68
Use useCallback
df3e94d
Moved check for table before getting leavesQty
b7cebd9
Removed unused file
1d6280b
Added mocking of notification middleware
6288ec0
Use fuel to run component drivers
ce79103
Executing renders by step
afd8c6d
Trying out custom parser
a22d9e5
Fixing up mock responses
02468dd
Added tests for cross order
bb66b3f
@Effanuel Effanuel added the enhancement New feature or request label Nov 13, 2020
@Effanuel Effanuel linked an issue Nov 13, 2020 that may be closed by this pull request
Crossover_BUY order and Cross_under SELL order for market order and trailing limit orders) #20
Open
@Effanuel Effanuel merged commit 759775b into master Nov 13, 2020
@Effanuel Effanuel deleted the Cross-Orders branch July 21, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crossover_BUY order and Cross_under SELL order for market order and trailing limit orders)
1 participant
@Effanuel