Redundant dependencies in andino_apps and andino_bringup for humble version

[Plumezz]

Hello, after building and testing this project with branch humble, I found something unexpected.

I noticed the package.xml files in andino_apps and andino_bringup contain the following content which means a format check.

  <test_depend>ament_lint_auto</test_depend>
  <test_depend>ament_lint_common</test_depend>

But there are no test section in CMakeLists.txt resulting in no testing programs to run actually.

So I think if we want the ament_lint tools to do a format check, maybe need add the testing section in the CMakeLists.txt like following:

if(BUILD_TESTING)
  find_package(ament_lint_auto REQUIRED)
  ament_lint_auto_find_test_dependencies()
endif()

After adding the content, amen_lint_tools like ament_pep257, ament_copyright, ament_flake8, ament_lint_cmake, ament_xmllint can be executed correctly when I use colcon test command.

But there are some stytle errors. Here is the test result about andino_apps and andino_bringup:

andino_bringup_result.txt 1:copyright 2:flake8 5:xmllint

andino_apps_result.txt 1:copyright 5:xmllint

If we do not need the ament_lint_tools, I think the test_depend might be a redundant dependency that could be removed to reduce the burden of project maintenance.

I would appreciate it if you could tell me how do you think of this?

Thanks!

[Plumezz]

Package andino_control might also have a redundant test_depend.

Its package.xml file contains <test_depend>ament_cmake_clang_format</test_depend>, but there are no matching files like .c .cpp .h in the package. And CMakeLists.txt also has no test section.