Skip to content

Commit e361367

Browse files
authored
Merge pull request #849 from gorsheninmv/get-back-net6-support
Get back net6 support
2 parents 7ca40bc + 1864c21 commit e361367

File tree

4 files changed

+21
-8
lines changed

4 files changed

+21
-8
lines changed

.github/workflows/ci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
uses: actions/setup-dotnet@v4
1818
with:
1919
dotnet-version: |
20+
6.0.x
2021
8.0.x
2122
2223
- name: Build
@@ -32,6 +33,7 @@ jobs:
3233
uses: actions/setup-dotnet@v4
3334
with:
3435
dotnet-version: |
36+
6.0.x
3537
8.0.x
3638
3739
- name: Build

nuke/Build.cs

+17-5
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ AbsolutePath[] Projects
7171
}
7272
}
7373

74+
string Framework => Solution.GetProject(DemoTargetLibName).GetProperty("TargetFramework");
75+
7476
protected override void OnBuildInitialized()
7577
{
7678
var parser = new ReleaseNotesParser();
@@ -184,7 +186,9 @@ protected override void OnBuildInitialized()
184186
var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj";
185187
var args = "build /target custom win7-x86;win /dotnet-configuration Debug /electron-arch ia32 /electron-params \"--publish never\"";
186188

187-
DotNet($"run --project {cli} -- {args}", sample);
189+
var cmd = $"run --project {cli} --framework {Framework} -- {args}";
190+
Log.Debug(cmd);
191+
DotNet(cmd, sample);
188192
});
189193

190194
Target ElectronizeWindowsTargetSample => _ => _
@@ -195,7 +199,9 @@ protected override void OnBuildInitialized()
195199
var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj";
196200
var args = "build /target win /electron-params \"--publish never\"";
197201

198-
DotNet($"run --project {cli} -- {args}", sample);
202+
var cmd =$"run --project {cli} --framework {Framework} -- {args}";
203+
Log.Debug(cmd);
204+
DotNet(cmd, sample);
199205
});
200206

201207
Target ElectronizeCustomWin7TargetSample => _ => _
@@ -206,7 +212,9 @@ protected override void OnBuildInitialized()
206212
var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj";
207213
var args = "build /target custom win7-x86;win /electron-params \"--publish never\"";
208214

209-
DotNet($"run --project {cli} -- {args}", sample);
215+
var cmd =$"run --project {cli} --framework {Framework} -- {args}";
216+
Log.Debug(cmd);
217+
DotNet(cmd, sample);
210218
});
211219

212220
Target ElectronizeMacOsTargetSample => _ => _
@@ -217,7 +225,9 @@ protected override void OnBuildInitialized()
217225
var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj";
218226
var args = "build /target osx /electron-params \"--publish never\"";
219227

220-
DotNet($"run --project {cli} -- {args}", sample);
228+
var cmd =$"run --project {cli} --framework {Framework} -- {args}";
229+
Log.Debug(cmd);
230+
DotNet(cmd, sample);
221231
});
222232

223233
Target ElectronizeLinuxTargetSample => _ => _
@@ -228,7 +238,9 @@ protected override void OnBuildInitialized()
228238
var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj";
229239
var args = "build /target linux /electron-params \"--publish never\"";
230240

231-
DotNet($"run --project {cli} -- {args}", sample);
241+
var cmd =$"run --project {cli} --framework {Framework} -- {args}";
242+
Log.Debug(cmd);
243+
DotNet(cmd, sample);
232244
});
233245

234246
Target PublishPackages => _ => _

src/ElectronNET.API/ElectronNET.API.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFramework>net8.0</TargetFramework>
3+
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
44
<PackageOutputPath>..\..\artifacts</PackageOutputPath>
55
<PackageId>ElectronNET.API</PackageId>
66
<Authors>Gregor Biswanger, Florian Rappl</Authors>

src/ElectronNET.CLI/ElectronNET.CLI.csproj

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<OutputType>Exe</OutputType>
4-
<TargetFramework>net8.0</TargetFramework>
4+
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
55
<AssemblyName>dotnet-electronize</AssemblyName>
66
<ToolCommandName>electronize</ToolCommandName>
77
<PackageType>DotnetCliTool</PackageType>
@@ -25,7 +25,6 @@
2525
<PackageReleaseNotes>Changelog: https://github.com/ElectronNET/Electron.NET/blob/main/Changelog.md</PackageReleaseNotes>
2626
<PackageIcon>PackageIcon.png</PackageIcon>
2727
<PackAsTool>true</PackAsTool>
28-
<PublishSelfContained>true</PublishSelfContained>
2928
<StartupObject>
3029
</StartupObject>
3130
</PropertyGroup>

0 commit comments

Comments
 (0)