Fix tests

Author: ElliottKasoar

.ci/opensearch/action.yml

@@ -20,7 +20,7 @@ inputs:
   opensearch-initial-admin-password:
     description: 'The password for the user admin in your cluster'
     required: false
-    default: 'myStrongPassword123!'
+    default: 'myStrongPassword_123'
 
 runs:
   using: 'docker'

tests/test_opensearch.py

@@ -26,8 +26,7 @@ def skip_if_not_github_actions():
 def abcd():
     """Set up OpenSearch database connection."""
     security_enabled = os.getenv("security_enabled") == "true"
-    # credential = "admin:myStrongPassword123!"
-    credential = "admin:admin"
+    credential = "admin:myStrongPassword_123"
 
     logging.basicConfig(level=logging.INFO)
 

tests/test_opensearch_mock.py

@@ -17,9 +17,14 @@ def abcd():
     """Set up database connection."""
     port = int(os.environ.get("port", 9200))
     host = "localhost"
-    security_enabled = os.getenv("security_enabled") == "true"
-    # credential = "admin:myStrongPassword123!"
-    credential = "admin:admin"
+    # If running in CI, enable/disable security
+    if os.getenv("GITHUB_ACTIONS") == "true":
+        security_enabled = os.getenv("security_enabled") == "true"
+    else:
+        # Otherwise assume local OpenSearch is enabled
+        security_enabled = True
+
+    credential = "admin:myStrongPassword_123"
 
     logging.basicConfig(level=logging.INFO)
 
@@ -33,7 +38,7 @@ def abcd():
     return opensearch_abcd
 
 
-def test_destroy(self, abcd):
+def test_destroy(abcd):
     """
     Test destroying database index.
     """
@@ -42,7 +47,7 @@ def test_destroy(self, abcd):
     assert abcd.client.indices.exists("test_index") is False
 
 
-def test_create(self, abcd):
+def test_create(abcd):
     """
     Test creating database index.
     """
@@ -52,7 +57,7 @@ def test_create(self, abcd):
     assert abcd.client.indices.exists("fake_index") is False
 
 
-def test_push(self, abcd):
+def test_push(abcd):
     """
     Test pushing atoms objects to database individually.
     """