Fix lints

Author: Jake-Shadle

.cargo/config.toml

@@ -43,7 +43,6 @@ rustflags = [
     "-Wclippy::map_err_ignore",
     "-Wclippy::map_flatten",
     "-Wclippy::map_unwrap_or",
-    "-Wclippy::match_on_vec_items",
     "-Wclippy::match_same_arms",
     "-Wclippy::match_wild_err_arm",
     "-Wclippy::match_wildcard_for_single_variants",

crash-handler/src/lib.rs

@@ -36,9 +36,9 @@ pub fn write_stderr(s: &'static str) {
 
 cfg_if::cfg_if! {
     if #[cfg(all(unix, not(target_os = "macos")))] {
-        /// The sole purpose of the unix module is to hook pthread_create to ensure
+        /// The sole purpose of the unix module is to hook `pthread_create` to ensure
         /// an alternate stack is installed for every native thread in case of a
-        /// stack overflow. This doesn't apply to MacOS as it uses exception ports,
+        /// stack overflow. This doesn't apply to `MacOS` as it uses exception ports,
         /// which are always delivered to a specific thread owned by the exception
         /// handler
         pub mod unix;

minidumper-test/src/lib.rs

@@ -101,15 +101,14 @@ fn make_dump_path(id: &str) -> PathBuf {
 pub fn spinup_server(id: &str, dump_path: Option<PathBuf>) -> Server {
     let dump_path = dump_path.unwrap_or_else(|| make_dump_path(id));
 
-    if dump_path.exists() {
-        if let Err(e) = std::fs::remove_file(&dump_path) {
+    if dump_path.exists()
+        && let Err(e) = std::fs::remove_file(&dump_path) {
             panic!(
                 "failed to remove existing dump file {}: {}",
                 dump_path.display(),
                 e
             );
         }
-    }
 
     let mut server = minidumper::Server::with_name(id).expect("failed to start server");
 

minidumper/examples/diskwrite.rs

@@ -21,11 +21,10 @@ fn main() {
 
                 let dump_path = std::path::PathBuf::from(format!("dumps/{uuid}.dmp"));
 
-                if let Some(dir) = dump_path.parent() {
-                    if !dir.try_exists()? {
+                if let Some(dir) = dump_path.parent()
+                    && !dir.try_exists()? {
                         std::fs::create_dir_all(dir)?;
                     }
-                }
                 let file = std::fs::File::create(&dump_path)?;
                 Ok((file, dump_path))
             }

minidumper/src/ipc/server.rs

@@ -472,7 +472,7 @@ impl Server {
                 // many layers, so really, we are falling back on Windows to actually correctly handle
                 // if the interior pointers have become invalid which it should? do ok with
                 let result =
-                    minidump_writer::minidump_writer::MinidumpWriter::dump_crash_context(crash_context, None, &mut minidump_file);
+                    minidump_writer::minidump_writer::MinidumpWriter::dump_crash_context(&crash_context, None, &mut minidump_file);
             } else if #[cfg(target_os = "macos")] {
                 let mut writer = minidump_writer::minidump_writer::MinidumpWriter::with_crash_context(crash_context);
                 let result = writer.dump(&mut minidump_file);