Fix UB in install_handlers (#94)

Chain-Fox · web-flow · commit 6e61b464526a · 2025-05-13T13:45:31.000+02:00
diff --git a/crash-handler/src/linux/state.rs b/crash-handler/src/linux/state.rs
@@ -251,10 +251,8 @@ pub unsafe fn install_handlers() {
 
         // Everything is initialized. Transmute the array to the
         // initialized type.
-        *ohl = Some(mem::transmute::<
-            [std::mem::MaybeUninit<libc::sigaction>; 6],
-            [libc::sigaction; 6],
-        >(old_handlers));
+        let old_handlers = old_handlers.map(|h| h.assume_init());
+        *ohl = Some(old_handlers);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -251,10 +251,8 @@ pub unsafe fn install_handlers() {`
`251`	`251`
`252`	`252`	`// Everything is initialized. Transmute the array to the`
`253`	`253`	`// initialized type.`
`254`		`- *ohl = Some(mem::transmute::<`
`255`		`- [std::mem::MaybeUninit<libc::sigaction>; 6],`
`256`		`- [libc::sigaction; 6],`
`257`		`- >(old_handlers));`
	`254`	`+ let old_handlers = old_handlers.map(\|h\| h.assume_init());`
	`255`	`+ *ohl = Some(old_handlers);`
`258`	`256`	`}`
`259`	`257`	`}`
`260`	`258`