Prep minidumper release (#50)

* Update minidump-writer

* Align crash-context

* Update CHANGELOG

* Fix CI

* Fix x86 sigfpe test

Author: Jake-Shadle

.github/workflows/rust-ci.yml

@@ -32,7 +32,7 @@ jobs:
       - run: cargo fetch
       - name: cargo clippy
         run: |
-          cargo clippy -p crash-context -p crash-handler -p sadness-generator --all-targets --all-features -- -D warnings
+          cargo clippy --all-targets --all-features -- -D warnings
 
   test:
     name: Test
@@ -45,9 +45,9 @@ jobs:
       - uses: dtolnay/rust-toolchain@stable
       - run: cargo fetch
       - name: cargo test build
-        run: cargo build -p crash-context -p crash-handler -p sadness-generator --tests
+        run: cargo build --tests
       - name: cargo test
-        run: cargo test -p crash-context -p crash-handler -p sadness-generator
+        run: cargo test
 
   deny-check:
     name: cargo-deny
@@ -65,6 +65,7 @@ jobs:
       - run: cargo fetch
       - name: cargo publish check
         run: |
-          cargo publish --dry-run --manifest-path crash-handler/Cargo.toml
-          #cargo publish --dry-run --manifest-path minidumper/Cargo.toml
           cargo publish --dry-run --manifest-path crash-context/Cargo.toml
+          cargo publish --dry-run --manifest-path crash-handler/Cargo.toml
+          cargo publish --dry-run --manifest-path minidumper/Cargo.toml
+          cargo publish --dry-run --manifest-path sadness-generator/Cargo.toml

Cargo.toml

@@ -9,8 +9,3 @@ members = [
 
 [profile.dev]
 debug = 2
-
-[patch.crates-io]
-minidump-writer = { git = "https://github.com/rust-minidump/minidump-writer", branch = "exc-encoding" }
-#minidump-writer = { path = "../mdw" }
-crash-context = { path = "crash-context" }

crash-handler/Cargo.toml

@@ -22,7 +22,7 @@ debug-print = []
 cfg-if = "1.0"
 # Definition of a portable crash-context that can be shared between various
 # crates
-crash-context = { version = "0.4", path = "../crash-context" }
+crash-context = "0.4"
 # Wrapper around libc
 libc = "0.2"
 # Nicer sync primitives

minidumper-test/src/lib.rs

@@ -419,10 +419,20 @@ pub fn assert_minidump(md_buf: &[u8], signal: Signal) {
                 ));
             }
             Signal::Fpe => {
-                verify!(CrashReason::MacGeneral(
-                    errors::ExceptionCodeMac::EXC_ARITHMETIC,
-                    0
-                ));
+                cfg_if::cfg_if! {
+                    if #[cfg(target_arch = "aarch64")] {
+                        verify!(CrashReason::MacGeneral(
+                            errors::ExceptionCodeMac::EXC_ARITHMETIC,
+                            0
+                        ));
+                    } else if #[cfg(target_arch = "x86_64")] {
+                        verify!(CrashReason::MacArithmeticX86(
+                            errors::ExceptionCodeMacArithmeticX86Type::EXC_I386_DIV,
+                        ));
+                    } else {
+                        panic!("this target architecture is not supported on mac");
+                    }
+                }
             }
             Signal::Illegal => {
                 cfg_if::cfg_if! {

minidumper/CHANGELOG.md

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 <!-- next-header -->
 ## [Unreleased] - ReleaseDate
+### Changed
+- [PR#50](https://github.com/EmbarkStudios/crash-handling/pull/50) updated `minidump-writer` to take advantage of improvements in writing macos minidumps.
+
 ## [0.4.0] - 2022-07-19
 ### Changed
 - [PR#41](https://github.com/EmbarkStudios/crash-handling/pull/41) added support for detecting stale client connections for cases where the OS might not efficiently close the client end of the connection so that the server notices and removes the client from the event loop.

minidumper/Cargo.toml

@@ -19,12 +19,12 @@ keywords = ["crash", "minidump", "ipc", "out-of-process"]
 [dependencies]
 # Nicer cfg handling
 cfg-if = "1.0"
-crash-context = { version = "0.4", path = "../crash-context" }
+crash-context = "0.4"
 libc = "0.2"
 # Basic log emitting
 log = "0.4"
 # Minidump writing
-minidump-writer = "0.3"
+minidump-writer = "0.4"
 # Event loop
 polling = "2.2"
 # Nicer locking primitives