enable lints from workspace for puffin_http (#238)

### Checklist

* [X] I have read the [Contributor Guide](../CONTRIBUTING.md)
* [X] I have read and agree to the [Code of
Conduct](../CODE_OF_CONDUCT.md)
* [X] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

Enable lints from workspace for `puffin_http` and fix the report from
lints.

### Related Issues

No related issue.

Author: gwen-lg

puffin_http/Cargo.toml

@@ -27,3 +27,6 @@ puffin = { version = "0.19.1", path = "../puffin", features = [
 [dev-dependencies]
 simple_logger = "4.2"
 paste = "1.0.15"
+
+[lints]
+workspace = true

puffin_http/examples/server.rs

@@ -1,3 +1,6 @@
+#[expect(clippy::unwrap_used)]
+#[expect(clippy::print_stderr)]
+#[expect(clippy::infinite_loop)]
 fn main() {
     simple_logger::SimpleLogger::new()
         .with_level(log::LevelFilter::Info)
@@ -28,7 +31,7 @@ fn main() {
         sleep_ms(14);
         if frame_counter % 7 == 0 {
             puffin::profile_scope!("Spike");
-            std::thread::sleep(std::time::Duration::from_millis(10))
+            std::thread::sleep(std::time::Duration::from_millis(10));
         }
 
         for _ in 0..1000 {

puffin_http/src/client.rs

@@ -44,8 +44,8 @@ impl Client {
             frame_view: frame_view.clone(),
         };
 
-        let _ = std::thread::Builder::new()
-            .name("http_client_thread".to_string())
+        let _: std::thread::JoinHandle<()> = std::thread::Builder::new()
+            .name("http_client_thread".to_owned())
             .spawn(move || {
                 log::info!("Connecting to {}…", addr);
                 while alive.load(SeqCst) {
@@ -78,7 +78,8 @@ impl Client {
                         }
                     }
                 }
-            });
+            })
+            .expect("Failed to spawn client thread");
 
         client
     }

puffin_http/src/server.rs

@@ -1,7 +1,7 @@
 use anyhow::Context as _;
 use puffin::{FrameSinkId, GlobalProfiler, ScopeCollection};
 use std::{
-    io::Write,
+    io::Write as _,
     net::{SocketAddr, TcpListener, TcpStream},
     sync::{
         Arc,
@@ -27,7 +27,11 @@ pub struct Server {
 impl Server {
     /// Start listening for connections on this addr (e.g. "0.0.0.0:8585")
     ///
-    /// Connects to the [GlobalProfiler]
+    /// Connects to the [`GlobalProfiler`]
+    ///
+    /// # Errors
+    ///
+    /// forward error from [`Self::new_custom`] call.
     pub fn new(bind_addr: &str) -> anyhow::Result<Self> {
         fn global_add(sink: puffin::FrameSink) -> FrameSinkId {
             GlobalProfiler::lock().add_sink(sink)
@@ -47,7 +51,7 @@ impl Server {
     /// * `sink_install` - A function that installs the [Server]'s sink into
     ///   a [`GlobalProfiler`], and then returns the [`FrameSinkId`] so that the sink can be removed later
     /// * `sink_remove` - A function that reverts `sink_install`.
-    ///   This should be a call to remove the sink from the profiler ([GlobalProfiler::remove_sink])
+    ///   This should be a call to remove the sink from the profiler ([`GlobalProfiler::remove_sink`])
     ///
     /// # Example
     ///
@@ -56,6 +60,11 @@ impl Server {
     /// instance for the main UI loop, and another for the background worker loop, and events/frames from those thread(s)
     /// would be completely separated. You can then hook up two separate instances of `puffin_viewer` and profile them separately.
     ///
+    /// # Errors
+    ///
+    /// Will return an `io::Error` if the [`TcpListener::bind`] fail.
+    /// Will return an `io::Error` if the spawn of the thread ,for connection and data send management, fail.
+    ///
     /// ## Per-Thread Profiling
     /// ```
     /// # use puffin::GlobalProfiler;
@@ -269,7 +278,7 @@ impl Server {
             tx.send(frame).ok();
         }));
 
-        Ok(Server {
+        Ok(Self {
             sink_id,
             join_handle: Some(join_handle),
             num_clients,
@@ -380,7 +389,7 @@ impl PuffinServerImpl {
 
         packet
             .write_all(&crate::PROTOCOL_VERSION.to_le_bytes())
-            .unwrap();
+            .context("Encode puffin `PROTOCOL_VERSION` in packet to be send to client.")?;
 
         let scope_collection = if self.send_all_scopes {
             Some(&self.scope_collection)
@@ -415,6 +424,7 @@ impl PuffinServerImpl {
     }
 }
 
+#[expect(clippy::needless_pass_by_value)]
 fn client_loop(
     packet_rx: crossbeam_channel::Receiver<Packet>,
     client_addr: SocketAddr,