Remove /debug/pprof/allocs/flamegraph

glindstedt · glindstedt · commit 4f3766b5cd12 · 2025-11-05T11:53:32.000+01:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -224,7 +224,7 @@ corrosion-utils = { path = "crates/corrosion-utils" }
 eyre = "0.6.12"
 enum-map = "2.7.3"
 futures = "0.3.31"
-jemalloc_pprof = { version = "0.8", features = ["symbolize", "flamegraph"] }
+jemalloc_pprof = { version = "0.8", features = ["symbolize"] }
 kube = { version = "1.1", features = [
     "runtime",
     "rustls-tls",
diff --git a/about.toml b/about.toml
@@ -36,7 +36,3 @@ accepted = ["ISC", "OpenSSL"]
 
 [xxhash-rust]
 accepted = ["BSL-1.0"]
-
-# TODO is it acceptable?
-[inferno]
-accepted = ["CDDL-1.0"]
diff --git a/deny.toml b/deny.toml
@@ -80,5 +80,4 @@ exceptions = [
     # This license should not really be used for code, but here we are
     { crate = "notify", allow = ["CC0-1.0"] },
     { crate = "webpki-roots", allow = ["CDLA-Permissive-2.0"] },
-    { crate = "inferno", allow = ["CDDL-1.0"] },
 ]
diff --git a/src/components/admin.rs b/src/components/admin.rs
@@ -113,16 +113,6 @@ async fn handle_request<C: serde::Serialize>(
                 .body(Body::new(Bytes::from(msg)))
                 .unwrap(),
         },
-        #[cfg(all(feature = "jemalloc", not(target_env = "msvc")))]
-        (&Method::GET, "/debug/pprof/allocs/flamegraph") => {
-            match handle_get_heap_flamegraph().await {
-                Ok(response) => response,
-                Err((status_code, msg)) => Response::builder()
-                    .status(status_code)
-                    .body(Body::new(Bytes::from(msg)))
-                    .unwrap(),
-            }
-        }
         #[cfg(target_os = "linux")]
         (&Method::GET, "/debug/pprof/profile") => {
             let duration = request.uri().query().and_then(|query| {
@@ -386,19 +376,6 @@ async fn handle_get_heap() -> Result<Response<Body>, (StatusCode, String)> {
         .map_err(|err| (StatusCode::INTERNAL_SERVER_ERROR, err.to_string()))
 }
 
-#[cfg(all(feature = "jemalloc", not(target_env = "msvc")))]
-async fn handle_get_heap_flamegraph() -> Result<Response<Body>, (StatusCode, String)> {
-    let mut prof_ctl = jemalloc_pprof::PROF_CTL.as_ref().unwrap().lock().await;
-    require_profiling_activated(&prof_ctl)?;
-    let svg = prof_ctl
-        .dump_flamegraph()
-        .map_err(|err| (StatusCode::INTERNAL_SERVER_ERROR, err.to_string()))?;
-    Response::builder()
-        .header(hyper::header::CONTENT_TYPE, "image/svg+xml")
-        .body(Body::from(svg))
-        .map_err(|err| (StatusCode::INTERNAL_SERVER_ERROR, err.to_string()))
-}
-
 #[cfg(test)]
 mod tests {
 

Original file line number	Diff line number	Diff line change
`@@ -80,5 +80,4 @@ exceptions = [`
`80`	`80`	`# This license should not really be used for code, but here we are`
`81`	`81`	`{ crate = "notify", allow = ["CC0-1.0"] },`
`82`	`82`	`{ crate = "webpki-roots", allow = ["CDLA-Permissive-2.0"] },`
`83`		`- { crate = "inferno", allow = ["CDDL-1.0"] },`
`84`	`83`	`]`