Fix windows (#87)

- **Add windows compile check**
- **Fix windows**

Resolves: #86

Author: Jake-Shadle

.github/workflows/rust-ci.yml

@@ -10,7 +10,12 @@ name: CI
 jobs:
   lint:
     name: Lint
-    runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        os:
+          - ubuntu-22.04
+          - windows-2022
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
@@ -36,7 +41,6 @@ jobs:
       matrix:
         os:
           - ubuntu-22.04
-          #- windows-2022
         features: ["--features git", "--features sparse", "--features local-builder,sparse"]
     runs-on: ${{ matrix.os }}
     steps:

CHANGELOG.md

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 <!-- next-header -->
 ## [Unreleased] - ReleaseDate
+### Fixed
+- [PR#87](https://github.com/EmbarkStudios/tame-index/pull/87) resolved [#86](https://github.com/EmbarkStudios/tame-index/issues/86) by adding a missing `unsafe` that caused the Windows target to fail to compile.
+
 ## [0.20.0] - 2025-04-07
 ### Fixed
 - [PR#85](https://github.com/EmbarkStudios/tame-index/pull/85) updated gix -> 0.71 and tokio to 1.44.2, addressing [RUSTSEC-2025-0021](https://rustsec.org/advisories/RUSTSEC-2025-0021) and [RUSTSEC-2025-0023](https://rustsec.org/advisories/RUSTSEC-2025-0023).

src/utils/flock/win_bindings.rs

@@ -6,7 +6,7 @@
     clippy::upper_case_acronyms
 )]
 #[link(name = "kernel32")]
-extern "system" {
+unsafe extern "system" {
     #[link_name = "CloseHandle"]
     pub fn close_handle(object: Handle) -> Bool;
     #[link_name = "CreateEventA"]

src/utils/flock/windows.rs

@@ -75,10 +75,7 @@ fn flock(file: &File, flags: u32, timeout: Option<Duration>) -> Result {
         {
             let err = Error::last_os_error();
 
-            if err
-                .raw_os_error()
-                .map_or(false, |x| x == Win32Error::ErrorIoPending as i32)
-            {
+            if err.raw_os_error() == Some(Win32Error::ErrorIoPending as i32) {
                 let timeout = timeout.map_or(0, |dur| {
                     let millis = dur.as_millis();
                     if millis >= Infinite as u128 {
@@ -120,19 +117,17 @@ pub(super) fn unlock(file: &File) -> Result {
 
 #[inline]
 pub(super) fn is_contended(err: &Error) -> bool {
-    err.raw_os_error()
-        .map_or(false, |x| x == Win32Error::ErrorLockViolation as i32)
+    err.raw_os_error() == Some(Win32Error::ErrorLockViolation as i32)
 }
 
 #[inline]
 pub(super) fn is_unsupported(err: &Error) -> bool {
-    err.raw_os_error()
-        .map_or(false, |x| x == Win32Error::ErrorInvalidFunction as i32)
+    err.raw_os_error() == Some(Win32Error::ErrorInvalidFunction as i32)
 }
 
 #[inline]
 pub(super) fn is_timed_out(err: &Error) -> bool {
-    err.raw_os_error().map_or(false, |x| {
+    err.raw_os_error().is_some_and(|x| {
         x == Win32Error::WaitTimeout as i32 || x == Win32Error::WaitIoCompletion as i32
     })
 }