Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash at exit and enable sim reconstruction #214

Open
eugenevinitsky opened this issue Aug 19, 2024 · 2 comments
Open

Fix crash at exit and enable sim reconstruction #214

eugenevinitsky opened this issue Aug 19, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request Low Priority

Comments

@eugenevinitsky
Copy link
Contributor

static void setCudaHeapSize()
{
// FIXME size limit for device side malloc:
size_t heap_size = 4ul1024ul1024ul*1024ul;

char* user_heap_size = getenv("MADRONA_MWGPU_DEVICE_HEAP_SIZE");
if (user_heap_size) {
    heap_size = strtoul(user_heap_size,nullptr,10);
}

REQ_CUDA(cudaDeviceSetLimit(cudaLimitMallocHeapSize,
                            heap_size));

}

@aaravpandya
Copy link
Collaborator

Closing this issue as it is not currently possible due to restrictions from madrona side. Also, we have verified that the sim does not crash at exit. Crashes at exit were mostly artifacts of mixing different python versions.

More info on sim reconstruction here - shacklettbp/madrona#36.

@eugenevinitsky
Copy link
Contributor Author

I'm going to reopen this and mark it low priority. I don't want to forget that this is something we want to fix.

@eugenevinitsky eugenevinitsky reopened this Oct 9, 2024
@eugenevinitsky eugenevinitsky added enhancement New feature or request Low Priority labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants