improve coverage

Author: EmilHvitfeldt

DESCRIPTION

@@ -32,6 +32,7 @@ Suggests:
     vdiffr,
     viridisLite
 Copyright: See LICENSE.note file.
+Config/testthat/edition: 3
 Encoding: UTF-8
 LazyData: true
 Roxygen: list(markdown = TRUE)

R/completeme.R

@@ -1,5 +1,5 @@
 # borrowed main bits from https://github.com/jimhester/completeme (when it is put on CRAN will import directly from it)
-
+# nocov start
 the <- new.env(parent = emptyenv())
 the$completions <- list()
 complete_token <- get(".completeToken", asNamespace("utils"))
@@ -137,3 +137,4 @@ paletteer_d_completer <- function(env) {
   rc.options(custom.completer = completeme)
   register_completion(paletteer = paletteer_d_completer)
 }
+# nocov end

R/paletteer_c_wrappers.R

@@ -37,19 +37,6 @@ paletteer_c_ggthemes <- function(name, n) {
 
   name <- try(match.arg(name, c(ggthemes_c_seq_names, ggthemes_c_div_names)), silent = T)
 
-  if (inherits(name, "try-error")) {
-    ggthemes_list <- paste(c(
-      ggthemes_c_seq_names,
-      ggthemes_c_div_names
-    ),
-    collapse = "\n"
-    )
-    stop(sprintf(
-      'Error in match.arg, "arg" should be one of: \n%s',
-      ggthemes_list
-    ))
-  }
-
   if (name %in% ggthemes_c_seq_names) {
     pal_gen <- ggthemes::tableau_seq_gradient_pal(palette = name)
   } else {

tests/testthat/_snaps/paletteer_d.md

@@ -0,0 +1,8 @@
+# paletteer_d errors with wrong names
+
+    Code
+      paletteer_d("paletteer::notreal")
+    Condition
+      Error in `check_palette()`:
+      ! Palette not found. Make sure both package and palette name are spelled correct in the format "package::palette"
+

tests/testthat/test-paletteer_c.R

@@ -1,5 +1,3 @@
-context("test-paletteer_c")
-
 test_that("paletteer_c return correct number of colors", {
   expect_length(paletteer_c("grDevices::rainbow", 3), 3)
   expect_length(paletteer_c("grDevices::rainbow", 9), 9)
@@ -42,3 +40,24 @@ test_that("paletteer_c works when called from another function", {
     paletteer_c("grDevices::rainbow", 4)
   )
 })
+
+test_that("paletteer_c works with ggthemes", {
+  expect_identical(
+    length(paletteer_c("ggthemes::Blue", n = 4)),
+    4L
+  )
+
+  expect_identical(
+    length(paletteer_c("ggthemes::Orange-Blue Diverging", n = 5)),
+    5L
+  )
+})
+
+test_that("paletteer_c works with harrypotter", {
+  expect_identical(
+    length(paletteer_c("harrypotter::always", n = 4)),
+    4L
+  )
+})
+
+

tests/testthat/test-paletteer_c_wrappers.R

@@ -1,5 +1,3 @@
-context("test-paletteer_c-wrappers")
-
 test_that("paletteer_c_ggthemes return correct number of colors", {
   testthat::skip_if_not_installed("ggthemes")
   expect_length(paletteer_c_ggthemes("Blue", 10), 10)

tests/testthat/test-paletteer_d.R

@@ -1,5 +1,3 @@
-context("test-paletteer_d")
-
 test_that("paletteer_d return correct number of colors", {
   expect_length(paletteer_d("wesanderson::Royal1", 3), 3)
   expect_length(paletteer_d("grDevices::blues9", 9), 9)
@@ -66,3 +64,11 @@ test_that("palettes_d_names has the right number of rows", {
     nrow(palettes_d_names)
   )
 })
+
+test_that("paletteer_d errors with wrong names", {
+  expect_snapshot(
+    error = TRUE,
+    paletteer_d("paletteer::notreal")
+  )
+})
+

tests/testthat/test-paletteer_dynamic.R

@@ -1,5 +1,3 @@
-context("test-paletteer_dynamic")
-
 test_that("paletteer_dynamic return correct number of colors", {
   expect_length(paletteer_dynamic("ggthemes_solarized::green", 1), 1)
   expect_length(paletteer_dynamic("ggthemes_solarized::green", 3), 3)