Fix possible thread leak in PN when recompiled

PseudoKnight · PseudoKnight · commit 300752c00f52 · 2025-01-03T03:26:52.000-08:00
Bug affected the Persistence Network when it was configured to use a file data source (yml, json, ini, csv, xml). If a recompile is followed by garbage collection, a thread leak may occur. Setting corePoolSize to zero allows the thread to timeout, and ultimately the whole pool to be garbage collected.
diff --git a/src/main/java/com/laytonsmith/persistence/io/ReadWriteFileConnection.java b/src/main/java/com/laytonsmith/persistence/io/ReadWriteFileConnection.java
@@ -76,7 +76,7 @@ public ReadWriteFileConnection(URI uri, File workingDirectory, String blankDataM
 			reader.getTopLevelFile().createNewFile();
 		}
 		this.blankDataModel = blankDataModel;
-		this.service = new ThreadPoolExecutor(1, 1,
+		this.service = new ThreadPoolExecutor(0, 1,
 				60L, TimeUnit.MILLISECONDS,
 				new LinkedBlockingQueue<Runnable>(),
 				new ThreadFactory() {

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public ReadWriteFileConnection(URI uri, File workingDirectory, String blankDataM`
`76`	`76`	`reader.getTopLevelFile().createNewFile();`
`77`	`77`	`}`
`78`	`78`	`this.blankDataModel = blankDataModel;`
`79`		`- this.service = new ThreadPoolExecutor(1, 1,`
	`79`	`+ this.service = new ThreadPoolExecutor(0, 1,`
`80`	`80`	`60L, TimeUnit.MILLISECONDS,`
`81`	`81`	`new LinkedBlockingQueue<Runnable>(),`
`82`	`82`	`new ThreadFactory() {`