Skip to content

Commit c1f1e67

Browse files
committed
Mitigate OTP TLS 1.3 bug leaking message (#149)
OTP ssl can leak a message `{Ref, ok}` when key update is triggered, if the bug erlang/otp#10273 is present. Signed-off-by: Viktor Söderqvist <[email protected]>
1 parent b0a706d commit c1f1e67

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/ered_connection.erl

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -366,17 +366,17 @@ receive_data(0, _Time, Acc) ->
366366
{data, lists:unzip(lists:reverse(Acc))};
367367
receive_data(N, Time, Acc) ->
368368
receive
369-
Msg ->
370-
case Msg of
371-
{recv_exit, Reason} ->
372-
{recv_exit, Reason};
373-
{send, Pid, Ref, Commands} ->
374-
Data = ered_command:get_data(Commands),
375-
Class = ered_command:get_response_class(Commands),
376-
RefInfo = {Class, Pid, Ref, []},
377-
Acc1 = [{RefInfo, Data} | Acc],
378-
receive_data(N - 1, 0, Acc1)
379-
end
369+
{recv_exit, Reason} ->
370+
{recv_exit, Reason};
371+
{send, Pid, Ref, Commands} ->
372+
Data = ered_command:get_data(Commands),
373+
Class = ered_command:get_response_class(Commands),
374+
RefInfo = {Class, Pid, Ref, []},
375+
Acc1 = [{RefInfo, Data} | Acc],
376+
receive_data(N - 1, 0, Acc1);
377+
_Ignore ->
378+
%% Mitigate OTP TLS 1.3 bug #10273 leaking a message {Ref, ok}.
379+
receive_data(N, 0, Acc)
380380
after Time ->
381381
receive_data(0, 0, Acc)
382382
end.

0 commit comments

Comments
 (0)