Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed summary models for deepseek and openrouter, added TODOs for improving openrouter support #414

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

ErikBjare
Copy link
Owner

@ErikBjare ErikBjare commented Jan 21, 2025

Fixing issues found during #411


Important

Fix summary models for deepseek and openrouter, and add TODOs for openrouter improvements.

  • Behavior:
    • Fix _summarize_str in __init__.py to correctly handle model context and token limits using get_model().
    • Add TODOs in llm_openai.py for improving provider routing, setting required parameters, and quantization for openrouter.
  • Models:
    • Update get_summary_model() in models.py to return deepseek-chat for deepseek provider.

This description was created by Ellipsis for 6be1d41. It will automatically update as commits are pushed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (07ed85f) to head (6be1d41).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   69.98%   69.97%   -0.02%     
==========================================
  Files          70       70              
  Lines        5818     5816       -2     
==========================================
- Hits         4072     4070       -2     
  Misses       1746     1746              
Flag Coverage Δ
anthropic/claude-3-haiku-20240307 68.70% <100.00%> (-0.03%) ⬇️
openai/gpt-4o-mini 68.03% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare changed the title fix: added TODOs for better openrouter support fix: fixed summary models for deepseek and openrouter, added TODOs for improving openrouter support Jan 21, 2025
@ErikBjare ErikBjare marked this pull request as ready for review January 21, 2025 13:35
@ErikBjare ErikBjare merged commit d8a9bec into master Jan 21, 2025
7 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6be1d41 in 37 seconds

More details
  • Looked at 68 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. gptme/llm/__init__.py:186
  • Draft comment:
    Ensure that _chat_complete can handle model.full as input. It expects a model string, and using model.full might lead to unexpected behavior if not handled properly.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. gptme/llm/models.py:261
  • Draft comment:
    The addition of 'deepseek' in get_summary_model aligns with the changes in the MODELS dictionary, ensuring support for 'deepseek'.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a new provider 'deepseek' to the get_summary_model function. This is consistent with the changes made in the MODELS dictionary where 'deepseek' models are defined. The addition of 'deepseek' in get_summary_model ensures that a summary model is returned for this provider, which aligns with the intent of the PR to support 'deepseek'.

Workflow ID: wflow_L1KITvmLdn48cdwO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants