BugFix: Incorrect Site Navigation on Search (#649)

* Remove missing AOT compilation from project configuration

* Fixing incorrect condition

* Fixing bug in FloorSite not showing due to incorrect binding.

* Update search placeholder and refactor search logic

- Changed `SearchPlaceholder` to use correct resource "FloorFilterFilterSearchPlaceholder".
- Removed unused `InitializeLocalizedStrings` method from `FloorFilter`.
- Refactored `HandleSearchText_Changed` in `FloorFilterBrowseSitesPage` for improved search functionality and UI handling.

Author: prathameshnarkhede

src/Toolkit/Toolkit.Maui/FloorFilter/FloorFilter.MessageProperties.cs

@@ -31,7 +31,7 @@ public string? SearchPlaceholder
     /// Identifies the <see cref="SearchPlaceholder"/> bindable property.
     /// </summary>
     public static readonly BindableProperty SearchPlaceholderProperty =
-        BindableProperty.Create(nameof(SearchPlaceholder), typeof(string), typeof(FloorFilter), Properties.Resources.GetString("FloorFilterFilter"));
+        BindableProperty.Create(nameof(SearchPlaceholder), typeof(string), typeof(FloorFilter), Properties.Resources.GetString("FloorFilterFilterSearchPlaceholder"));
 
     /// <summary>
     /// Gets or sets the message shown to the user when a list or filtered list is empty.

src/Toolkit/Toolkit.Maui/FloorFilter/FloorFilter.cs

@@ -72,16 +72,6 @@ public FloorFilter()
         _controller.PropertyChanged += HandleControllerPropertyChanges;
     }
 
-    private void InitializeLocalizedStrings()
-    {
-        BrowseLabel = Properties.Resources.GetString("FloorFilterBrowse");
-        BrowseSitesLabel = Properties.Resources.GetString("FloorFilterBrowseSites");
-        BrowseFacilitiesLabel = Properties.Resources.GetString("FloorFilterBrowseFacilities");
-        NoResultsMessage = Properties.Resources.GetString("FloorFilterNoResultsFound");
-        AllFacilitiesLabel = Properties.Resources.GetString("FloorFilterAllFacilities");
-        SearchPlaceholder = Properties.Resources.GetString("FloorFilterFilter");
-    }
-
     /// <inheritdoc/>
     protected override void OnApplyTemplate()
     {

src/Toolkit/Toolkit.Maui/FloorFilter/FloorFilterBrowseSitesPage.cs

@@ -167,32 +167,30 @@ private void HandleListItem_Tapped(object? sender, SelectionChangedEventArgs e)
     private void HandleAllSites_Clicked(object? sender, EventArgs e) => _ff?.NavigateForward(new FloorFilterBrowseFacilitiesPage(_ff, true, true));
 
     private void HandleSearchText_Changed(object? sender, TextChangedEventArgs e)
-    {
-        if (!string.IsNullOrWhiteSpace(_searchBar.Text))
-        {
-            var simplified = _searchBar.Text.ToLower();
-            var results = _ff?.AllSites?.Where(site => site.Name.ToLower().Contains(simplified));
-
-            _filteredListView.ItemsSource = results;
-
-            if (results != null)
-            {
-                if (_ff?.SelectedSite != null && results.Contains(_ff.SelectedSite))
-                {
-                    _filteredListView.SelectedItem = _ff.SelectedSite;
-                }
-
-                _unfilteredListView.IsVisible = false;
-                _filteredListView.IsVisible = results.Any();
-            }
-            _noResultLabel.IsVisible = !(results?.Any() == true);
-        }
-        else
-        {
-            _filteredListView.ItemsSource = null;
-            _filteredListView.IsVisible = false;
-            _unfilteredListView.IsVisible = _itemsSource?.Any() == true;
-            _noResultLabel.IsVisible = !(_itemsSource?.Any() == true);
+    {
+        var searchText = _searchBar.Text;
+        if (!string.IsNullOrWhiteSpace(searchText))
+        {
+            var results = _ff?.AllSites?.Where(site =>
+                site.Name.Contains(searchText, StringComparison.CurrentCultureIgnoreCase));
+
+            bool hasResults = results?.Any() ?? false;
+
+            _filteredListView.ItemsSource = results;
+            _filteredListView.SelectedItem = null;
+
+            _unfilteredListView.IsVisible = false;
+            _filteredListView.IsVisible = hasResults;
+            _noResultLabel.IsVisible = !hasResults;
+        }
+        else
+        {
+            bool hasItems = _itemsSource?.Any() ?? false;
+
+            _filteredListView.ItemsSource = null;
+            _filteredListView.IsVisible = false;
+            _unfilteredListView.IsVisible = hasItems;
+            _noResultLabel.IsVisible = !hasItems;
         }
     }
 

src/Toolkit/Toolkit.UI.Controls/FloorFilter/FloorFilter.cs

@@ -88,7 +88,7 @@ private void InitializeLocalizedStrings()
             AllFacilitiesLabel = Properties.Resources.GetString("FloorFilterAllFacilities");
             BackButtonLabel = Properties.Resources.GetString("FloorFilterBackButton");
             AllFloorsLabel = Properties.Resources.GetString("FloorFilterAllFloors");
-            SearchPlaceholder = Properties.Resources.GetString("FloorFilterFilter");
+            SearchPlaceholder = Properties.Resources.GetString("FloorFilterFilterSearchPlaceholder");
         }
 
         /// <inheritdoc/>