Skip to content

Commit 4d0cb2a

Browse files
committed
Merge remote-tracking branch 'origin/dev' into 6646-advanced-table
* origin/dev: (322 commits) chore: add ui icons package to enhancement template (#11344) chore(table): move workaround comment back to its usage (#11341) ci(actions): refine remove-issue-from-design-projects workflow (#11325) chore(actions): add icon leads notification for calcite-ui-icons requests (#11263) test(combobox): use async expect for non-throwing test case (#11332) fix(combobox, input-time-zone): fix initial item selection delay (#11326) build(deps): update dependency type-fest to v4.32.0 (#11308) chore(utility-network-layer, crosshair): add font codepoints (#11336) refactor(loadable): deprecate obsolete helpers (#11312) chore: release next feat: add crosshair (#11331) build(deps): update arcgis to ^4.32.0-next.81 (#11273) ci(actions): add action to remove issues from design projects (#11249) chore: release next fix(list-item): reflect the sortHandleOpen property (#11323) refactor(block): heading text color (#11314) chore: release next fix(list): only focus on row when clicking a list item (#11310) fix(tooltip, popover): honor prevented events (#11278) chore: release next ...
2 parents 79a988a + 7954fef commit 4d0cb2a

File tree

2,747 files changed

+18670
-90063
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,747 files changed

+18670
-90063
lines changed

.cspell.json

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,21 @@
11
{
22
"dictionaries": [
33
"calcite-dev",
4+
"calcite-dev-examples",
5+
"cspell-pending-upstream",
46
"css",
57
"en-common-misspellings",
68
"fonts",
79
"fullstack",
10+
"gis",
811
"html",
912
"html-symbol-entities",
1013
"lorem-ipsum",
1114
"markdown",
1215
"node",
1316
"npm",
17+
"pokemon",
18+
"scientific-terms-us",
1419
"shell",
1520
"software-terms",
1621
"typescript"
@@ -19,6 +24,42 @@
1924
{
2025
"name": "calcite-dev",
2126
"path": "./support/dictionaries/dict-calcite-design-system.txt"
27+
},
28+
{
29+
"name": "calcite-dev-examples",
30+
"path": "./support/dictionaries/dict-calcite-design-system-examples.txt"
31+
},
32+
{
33+
"name": "cspell-pending-upstream",
34+
"path": "./support/dictionaries/dict-cspell-pending-upstream.txt"
35+
},
36+
{
37+
"name": "pokemon",
38+
"path": "./node_modules/@cspell/dict-pokemon/dict/pokemon.txt"
39+
}
40+
],
41+
"ignoreRegExpList": [
42+
"arcade-acronym-placeholder",
43+
"console-format-specifier",
44+
"embedded-png-source",
45+
"embedded-svg-source"
46+
],
47+
"patterns": [
48+
{
49+
"name": "arcade-acronym-placeholder",
50+
"pattern": "(?<!\\$)\\{\\w+\\}"
51+
},
52+
{
53+
"name": "console-format-specifier",
54+
"pattern": "%(s|i|d|f|o|O|c)"
55+
},
56+
{
57+
"name": "embedded-png-source",
58+
"pattern": "data:image\\/png;base64,\\w+"
59+
},
60+
{
61+
"name": "embedded-svg-source",
62+
"pattern": "data:image\\/svg\\+xml;.+\\w+"
2263
}
2364
]
2465
}

.github/ISSUE_TEMPLATE/accessibility.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Accessibility
22
description: Report an accessibility issue in a component
3-
labels: ["a11y", "bug", "0 - new", "p - high", "needs triage"]
3+
labels: ["a11y", "bug", "0 - new", "needs triage"]
44
body:
55
- type: checkboxes
66
id: existing-issues
@@ -9,8 +9,7 @@ body:
99
description: If someone has already opened an issue for what you are experiencing, please add a 👍 reaction to the existing issue instead of creating a new one. For support, please check the [community forum](https://developers.arcgis.com/calcite-design-system/community/).
1010
options:
1111
- label: I have [checked for existing issues](https://github.com/Esri/calcite-design-system/issues) to avoid duplicates and reviewed the [Accessibility page](https://developers.arcgis.com/calcite-design-system/foundations/accessibility) for guidance.
12-
validations:
13-
required: true
12+
required: true
1413
- type: textarea
1514
id: summary
1615
attributes:
@@ -36,7 +35,7 @@ body:
3635
attributes:
3736
label: Reproduction Sample
3837
description: |
39-
We provide the following templates to help get started: [codepen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [React Codesandbox](https://codesandbox.io/s/calcite-template-p95kp?file=/src/App.js) (Calcite with React wrapper), [Angular Codesandbox](https://codesandbox.io/p/sandbox/little-fire-2hx4qh?file=%2Fsrc%2Fapp%2Fapp.component.html%3A16%2C51), or [jsbin](https://jsbin.com/qecewik/edit?html,output) (Calcite with ArcGIS JSAPI). You can also make your own sample using one of the those websites. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
38+
We provide the following templates to help get started: [CodePen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [StackBlitz](https://stackblitz.com/github/esri/calcite-design-system/tree/dev/examples/components/react?file=README.md) (Calcite with React wrapper), or [JS Bin](https://jsbin.com/qecewik/edit?html,output) (Calcite with Maps SDK for JS). You can also click the "Open in StackBlitz" link at the top of each of [Calcite example's](https://github.com/Esri/calcite-design-system/tree/dev/examples/components) README or make your own from scratch. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
4039
validations:
4140
required: true
4241
- type: textarea
@@ -105,8 +104,6 @@ body:
105104
- label: "@esri/calcite-components-react"
106105
- label: "@esri/calcite-design-tokens"
107106
- label: "@esri/eslint-plugin-calcite-components"
108-
validations:
109-
required: false
110107
- type: dropdown
111108
id: esri-team
112109
validations:

.github/ISSUE_TEMPLATE/bug.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ body:
99
description: If someone has already opened an issue for what you are experiencing, please add a 👍 reaction to the existing issue instead of creating a new one. For support, please check the [community forum](https://developers.arcgis.com/calcite-design-system/community/).
1010
options:
1111
- label: I have [checked for existing issues](https://github.com/Esri/calcite-design-system/issues) to avoid duplicates
12-
validations:
13-
required: true
12+
required: true
1413
- type: textarea
1514
id: actual
1615
attributes:
@@ -30,7 +29,7 @@ body:
3029
attributes:
3130
label: Reproduction Sample
3231
description: |
33-
We provide the following templates to help get started: [codepen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [React Codesandbox](https://codesandbox.io/s/calcite-template-p95kp?file=/src/App.js) (Calcite with React wrapper), [Angular Codesandbox](https://codesandbox.io/p/sandbox/little-fire-2hx4qh?file=%2Fsrc%2Fapp%2Fapp.component.html%3A16%2C51), or [jsbin](https://jsbin.com/qecewik/edit?html,output) (Calcite with ArcGIS JSAPI). You can also make your own sample using one of the those websites. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
32+
We provide the following templates to help get started: [CodePen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [StackBlitz](https://stackblitz.com/github/esri/calcite-design-system/tree/dev/examples/components/react?file=README.md) (Calcite with React wrapper), or [JS Bin](https://jsbin.com/qecewik/edit?html,output) (Calcite with Maps SDK for JS). You can also click the "Open in StackBlitz" link at the top of each of [Calcite example's](https://github.com/Esri/calcite-design-system/tree/dev/examples/components) README or make your own from scratch. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
3433
validations:
3534
required: true
3635
- type: textarea
@@ -100,8 +99,6 @@ body:
10099
- label: "@esri/calcite-design-tokens"
101100
- label: "@esri/calcite-ui-icons"
102101
- label: "@esri/eslint-plugin-calcite-components"
103-
validations:
104-
required: false
105102
- type: dropdown
106103
id: esri-team
107104
validations:

.github/ISSUE_TEMPLATE/enhancement.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ body:
99
description: If someone has already opened an issue for what you are experiencing, please add a 👍 reaction to the existing issue instead of creating a new one. For support, please check the [community forum](https://developers.arcgis.com/calcite-design-system/community/).
1010
options:
1111
- label: I have [checked for existing issues](https://github.com/Esri/calcite-design-system/issues) to avoid duplicates
12-
validations:
13-
required: true
12+
required: true
1413
- type: textarea
1514
id: description
1615
attributes:
@@ -67,9 +66,8 @@ body:
6766
- label: "@esri/calcite-components"
6867
- label: "@esri/calcite-components-react"
6968
- label: "@esri/calcite-design-tokens"
69+
- label: "@esri/calcite-ui-icons"
7070
- label: "@esri/eslint-plugin-calcite-components"
71-
validations:
72-
required: false
7371
- type: dropdown
7472
id: esri-team
7573
validations:

.github/ISSUE_TEMPLATE/refactor.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,3 @@ body:
4545
- label: "@esri/calcite-design-tokens"
4646
- label: "@esri/calcite-ui-icons"
4747
- label: "@esri/eslint-plugin-calcite-components"
48-
validations:
49-
required: false

.github/scripts/.eslintrc.json

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/scripts/.lintstagedrc.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
const baseConfig = require("../../.lintstagedrc.js");
2+
3+
module.exports = {
4+
...baseConfig,
5+
"*.{m,c,}js": ["eslint --fix", "prettier --write"],
6+
};

.github/scripts/addCalcitePackageLabel.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ module.exports = async ({ github, context }) => {
2424
github,
2525
context,
2626
label: package,
27+
// eslint-disable-next-line @cspell/spellchecker -- hex color
2728
color: "BFBEAF",
2829
description: `Issues specific to the @esri/${package} package.`,
2930
});

.github/scripts/eslint.config.cjs

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
const globals = require("globals");
2+
const eslint = require("@eslint/js");
3+
const tseslint = require("typescript-eslint");
4+
const cspellPlugin = require("@cspell/eslint-plugin");
5+
6+
module.exports = tseslint.config({
7+
files: ["**/*.{c,m,}js"],
8+
extends: [eslint.configs.recommended, tseslint.configs.recommended],
9+
plugins: { "@cspell": cspellPlugin },
10+
11+
languageOptions: {
12+
ecmaVersion: 2021,
13+
sourceType: "commonjs",
14+
globals: {
15+
...globals.node,
16+
},
17+
},
18+
19+
rules: {
20+
"comma-dangle": "off",
21+
"@cspell/spellchecker": ["warn", {}],
22+
"@typescript-eslint/no-require-imports": "off",
23+
},
24+
});
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
// @ts-check
2+
3+
// If the "calcite-ui-icons" label is added to an issue, generates a notification to the Icons team leads to review
4+
// The secret is formatted like so: icon-team-member-1, icon-team-member-2, icon-team-member-3
5+
// Note the script automatically adds the "@" character in to notify the icon team lead(s)
6+
7+
/** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */
8+
module.exports = async ({ github, context }) => {
9+
const { repo, owner } = context.repo;
10+
11+
const payload = /** @type {import('@octokit/webhooks-types').IssuesLabeledEvent} */ (context.payload);
12+
const {
13+
issue: { number },
14+
} = payload;
15+
16+
const { ICONS_TEAM } = process.env;
17+
18+
// Add a "@" character to notify the user
19+
const icon_leads = ICONS_TEAM?.split(",").map((v) => " @" + v.trim());
20+
21+
if (!icon_leads?.length) {
22+
console.error("unable to determine icon leads");
23+
process.exit(1);
24+
}
25+
26+
// Add a comment to issues with the 'calcite-ui-icons' label to notify icon team lead(s)
27+
await github.rest.issues.createComment({
28+
owner,
29+
repo,
30+
issue_number: number,
31+
body: `cc ${icon_leads}`,
32+
});
33+
};

0 commit comments

Comments
 (0)