Skip to content

Transition relevant components that use open prop to expanded per design decision #11225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 5 tasks
Elijbet opened this issue Jan 8, 2025 · 2 comments
Closed
1 of 5 tasks

Transition relevant components that use open prop to expanded per design decision #11225

Elijbet opened this issue Jan 8, 2025 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. calcite-components Issues specific to the @esri/calcite-components package. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-03-25 - 3.1....

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jan 8, 2025 •
edited
Loading

Description

block and list-item use open prop, but should use expanded per design decision. They need to transition to using expanded instead.

list-item has both open and closed. It looks like it should be expanded and closed.

  /** When `true`, the item is open to show child components. */
  @property({ reflect: true }) open = false;
  
  /** When `true`, hides the component. */
  @property({ reflect: true }) closed = false;

Proposed Advantages

Alignment with the design decision and consistency across components.

Which Component

block
block-section
list-item
list
and other relevant components

Relevant Info

Design decision: #6473
image

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 8, 2025
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Jan 8, 2025
@Elijbet Elijbet mentioned this issue Feb 18, 2025
Merged
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Feb 18, 2025
@Elijbet Elijbet self-assigned this Feb 18, 2025
@Elijbet Elijbet mentioned this issue Feb 18, 2025
Merged
Elijbet added a commit that referenced this issue Mar 5, 2025
@Elijbet
feat(list-item, list): add expanded property and deprecate open p…
359fd0d 
…roperty (#11003)

**Related Issue:** #6473, #11225

## Summary
Deprecate `open` prop in favor of `expanded`. Add logger warning for
deprecation to help inform users about the deprecated property and guide
them towards using the recommended alternatives.
Elijbet added a commit that referenced this issue Mar 5, 2025
@Elijbet
feat(block, block-section): add expanded property and deprecate `op…
046f410 
…en` property (#11582)

**Related Issue:** #6473, #11225

## Summary
Deprecate `open` prop in favor of `expanded`. Add logger warning for
deprecation to help inform users about the deprecated property and guide
them towards using the recommended alternatives.
benelan pushed a commit that referenced this issue Mar 26, 2025
@Elijbet @benelan
feat(list-item, list): add expanded property and deprecate open p…
c80c44c 
…roperty (#11003)

**Related Issue:** #6473, #11225

## Summary
Deprecate `open` prop in favor of `expanded`. Add logger warning for
deprecation to help inform users about the deprecated property and guide
them towards using the recommended alternatives.
benelan pushed a commit that referenced this issue Mar 26, 2025
@Elijbet @benelan
feat(block, block-section): add expanded property and deprecate `op…
999f532 
…en` property (#11582)

**Related Issue:** #6473, #11225

## Summary
Deprecate `open` prop in favor of `expanded`. Add logger warning for
deprecation to help inform users about the deprecated property and guide
them towards using the recommended alternatives.
@Elijbet Elijbet added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels Apr 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned Elijbet Apr 1, 2025
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Apr 15, 2025
@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Apr 29, 2025
@geospatialem
Copy link
Member

Verified with 3.1.0 for the deprecations of block and list-item's open in favor of expanded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. calcite-components Issues specific to the @esri/calcite-components package. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

No branches or pull requests
3 participants
@geospatialem @Elijbet @DitwanP