Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply openCloseComponent interface to components that use closed, collapsed, expanded props #11227

Open
2 of 5 tasks
Elijbet opened this issue Jan 8, 2025 · 0 comments
Open
2 of 5 tasks
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jan 8, 2025

Check existing issues

Description

There are a number of components that don’t use open prop, but alternatively use expanded, collapsed, and closed. These need to be applied the openCloseComponent interface once the utility is upgraded to account for these new props.

Blocked by: #9513

expanded:

accordion-item
action-group
action-menu
action-pad
tree-item

collapsed:

flow-item
panel
shell-panel

closed:

chip
list item
flow-item
panel
tab-title
tip
tip-manager

Acceptance Criteria

These components are openCloseComponents.

Relevant Info

Audit components open/closed props for consistency #6473

Which Component

See listed

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@Elijbet Elijbet added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 8, 2025
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

1 participant