Skip to content

Align space token naming for multiple components #12587

@matgalla

Description

@matgalla

Check existing issues

Description

Most component token names use space, but there are a few outliers that use spacing:

input-message

  • --calcite-input-message-spacing

loader

  • --calcite-loader-spacing
  • --calcite-loader-text-spacing

radio-button-group

  • --calcite-radio-button-input-message-spacing

rating

  • --calcite-rating-spacing

Acceptance Criteria

Component tokens using spacing are deprecated and new tokens using space are added

input-message

  • deprecate --calcite-input-message-spacing
  • add --calcite-input-message-space

loader

  • deprecate --calcite-loader-spacing
  • deprecate --calcite-loader-text-spacing
  • add --calcite-loader-space
  • add --calcite-loader-text-space

radio-button-group

  • deprecate --calcite-radio-button-input-message-spacing
  • add --calcite-radio-button-input-message-space

rating

  • deprecate --calcite-rating-spacing
  • add --calcite-rating-space

*also update deprecation notes pointing to tokens being deprecated

Relevant Info

Semantic tokens using spacing will also be updated to space in a future update

Which Component

input-message
loader
radio-button-group
rating

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

Metadata

Metadata

Assignees

No one assigned

    Labels

    0 - newNew issues that need assignment.Calcite (design)Issues logged by Calcite designers.c-input-messageIssues that pertain to the calcite-input-message componentc-loaderIssues that pertain to the calcite-loader componentc-radio-button-groupIssues that pertain to the calcite-radio-button-group componentc-ratingIssues that pertain to the calcite-rating componentdesign-tokensIssues requiring design tokens.enhancementIssues tied to a new feature or request.impact - p3 - not time sensitiveUser set priority impact status of p3 - not time sensitiveneeds triagePlanning workflow - pending design/dev review.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions