-
Notifications
You must be signed in to change notification settings - Fork 83
Open
Labels
ArcGIS HubIssues logged by ArcGIS Hub team members.Issues logged by ArcGIS Hub team members.bugBug reports for broken functionality. Issues should include a reproduction of the bug.Bug reports for broken functionality. Issues should include a reproduction of the bug.c-popoverIssues that pertain to the calcite-popover componentIssues that pertain to the calcite-popover componentcalcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.impact - p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestoneneeds triagePlanning workflow - pending design/dev review.Planning workflow - pending design/dev review.
Description
monday.com sync: #11135705311
Check existing issues
- I have checked for existing issues to avoid duplicates
Which Component
Popover
Actual Behavior
The updateFocusTrapElements() method on calcite-popover does not have a parameter to provide extra containers to add to the focus trap elements list, which prevents the intended functionality.
calcite-sheet and calcite-dialog have this method with an extraContainers parameter.
Expected Behavior
The updateFocusTrapElements() method has a extraContainers parameter and adds the arguments to the extra containers list, allowing those elements to be focusable within the trap.
Reproduction Sample
https://codepen.io/isaacbraun/pen/RNRxBZw
Reproduction Steps
- Open the CodePen
- Click the "Leave us a note" Popover
- Click the "Add" (plus icon) Action
- Note that a new button is added, but cannot be focused via tabbing within the Popover's trap.
Reproduction Version
5.0.0-next.81
Relevant Info
No response
Regression?
No response
Priority impact
impact - p2 - want for an upcoming milestone
Impact
No response
Calcite package
- @esri/calcite-components
- @esri/calcite-components-react
- @esri/calcite-design-tokens
- @esri/calcite-ui-icons
- @esri/eslint-plugin-calcite-components
Esri team
ArcGIS Hub
mjuniper
Metadata
Metadata
Assignees
Labels
ArcGIS HubIssues logged by ArcGIS Hub team members.Issues logged by ArcGIS Hub team members.bugBug reports for broken functionality. Issues should include a reproduction of the bug.Bug reports for broken functionality. Issues should include a reproduction of the bug.c-popoverIssues that pertain to the calcite-popover componentIssues that pertain to the calcite-popover componentcalcite-componentsIssues specific to the @esri/calcite-components package.Issues specific to the @esri/calcite-components package.impact - p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestoneUser set priority impact status of p2 - want for an upcoming milestoneneeds triagePlanning workflow - pending design/dev review.Planning workflow - pending design/dev review.