Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column / 50-50 & Media Split add start/end padding #455

Merged
merged 5 commits into from
Dec 25, 2024
Merged

Column / 50-50 & Media Split add start/end padding #455

merged 5 commits into from
Dec 25, 2024
+12 −2

Conversation

jsavella
Copy link
Contributor

@jsavella jsavella commented Dec 23, 2024 •
edited
Loading

@jsavella jsavella self-assigned this Dec 23, 2024
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 23, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@jsavella jsavella changed the title Fifty Fifty / Column add padding Fifty Fifty / Column add padding [hold] Dec 23, 2024
@twhite313 twhite313 marked this pull request as draft December 23, 2024 17:21
@twhite313 twhite313 marked this pull request as ready for review December 23, 2024 17:21
@jsavella jsavella changed the title Fifty Fifty / Column add padding [hold] Fifty Fifty / Column add padding Dec 23, 2024
@jsavella jsavella changed the title Fifty Fifty / Column add padding Column / 50-50 & Media Split add padding Dec 23, 2024
@jsavella jsavella changed the title Column / 50-50 & Media Split add padding Column / 50-50 & Media Split left right add padding Dec 23, 2024
@jsavella jsavella changed the title Column / 50-50 & Media Split left right add padding Column / 50-50 & Media Split add start/end padding Dec 23, 2024
twhite313
twhite313 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@twhite313 twhite313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image on right has padding block end for some reason -- coming from :last-child
But ignoring for now, focusing on just gutter.

@jsavella jsavella merged commit ff04f0d into main Dec 25, 2024
1 of 2 checks passed
@jsavella jsavella deleted the fiftyGutter branch December 25, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twhite313 twhite313 twhite313 approved these changes

@anu13297 anu13297 Awaiting requested review from anu13297

Assignees

@jsavella jsavella

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jsavella @twhite313 @webjsavella