Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select a basemap view does not respect safe area. #74

Open
esreli opened this issue Oct 29, 2018 · 3 comments
Open

Select a basemap view does not respect safe area. #74

esreli opened this issue Oct 29, 2018 · 3 comments

Comments

@esreli
Copy link
Contributor

esreli commented Oct 29, 2018

screen shot 2018-10-29 at 4 56 56 pm

@esreli
Copy link
Contributor Author

esreli commented Nov 1, 2018

@nixta I think we should consider updating the minimum deployment target to iOS 11 so that we may start using Safe Area layout guides instead of what's currently used for iOS, (Bottom Layout Guide & Top Layout Guide).

According to Mixpanel as of Monday Oct 29, 2018 only 6% of devices are running something older than iOS 11. I think this figure merits the deprecation, especially as more devices are introduced that require a safe area guide considerations.

Of course we could keep the minimum deployment target at iOS 10 and conditionally check if iOS 11 is available but then that begs the question, why would we if iOS adoption rate is so high?

Thoughts?

@nixta
Copy link
Member

nixta commented Nov 1, 2018

Runtime 100.4 continues to support iOS 10, so the example apps should support it too.

v.next should be targeting iOS 11 minimum, so I'm all for doing this work there.

That's just silly. I agree. We should set the minimum target to iOS 11 and update to use Safe Areas.

@esreli
Copy link
Contributor Author

esreli commented Nov 1, 2018

I've filed and issue: #77

@esreli esreli added this to the v1.1 milestone Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants