Skip to content

Commit 302653a

Browse files
CopilotJRoy
andauthored
Fix workflow artifact upload paths missing "X" in EssentialsX addon jar names (#6462)
### Information Workflow artifact upload steps referenced incorrect jar filenames — all addon jars are built as `EssentialsX{Addon}-*.jar` (e.g. `EssentialsXChat`, `EssentialsXProtect`) because project names in `settings.gradle.kts` are all prefixed with `EssentialsX`, and `archivesName` is set to `project.name`. The upload globs were missing the `X`, causing every per-module direct upload to fail to find its target file. ### Details **Proposed fix:** Update all per-module `archive: false` upload step paths in both `build-pr.yml` and `build-master.yml` to use the correct `EssentialsX`-prefixed names: | Before | After | |---|---| | `jars/EssentialsAntiBuild-*.jar` | `jars/EssentialsXAntiBuild-*.jar` | | `jars/EssentialsChat-*.jar` | `jars/EssentialsXChat-*.jar` | | `jars/EssentialsDiscord-*.jar` | `jars/EssentialsXDiscord-*.jar` | | `jars/EssentialsDiscordLink-*.jar` | `jars/EssentialsXDiscordLink-*.jar` | | `jars/EssentialsGeoIP-*.jar` | `jars/EssentialsXGeoIP-*.jar` | | `jars/EssentialsProtect-*.jar` | `jars/EssentialsXProtect-*.jar` | | `jars/EssentialsSpawn-*.jar` | `jars/EssentialsXSpawn-*.jar` | | `jars/EssentialsXMPP-*.jar` | `jars/EssentialsXXMPP-*.jar` | The Javadoc `cp` paths in `build-master.yml` reference filesystem directory names (which don't include `X`) and remain correct as-is. **Environments tested:** OS: N/A (CI workflow change only) Java version: N/A - ~~Most recent Paper version (1.XX.Y, git-Paper-BUILD)~~ - ~~CraftBukkit/Spigot/Paper 1.12.2~~ - ~~CraftBukkit 1.8.8~~ **Demonstration:** N/A — the incorrect globs would silently produce no artifact (or an error) for each addon module on every workflow run using `archive: false`. <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > https://github.blog/changelog/2026-02-26-github-actions-now-supports-uploading-and-downloading-non-zipped-artifacts/ > > update our workflows to use this rather than zipping (still provide the zip but also individually upload </details> <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/EssentialsX/Essentials/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JRoy <10731363+JRoy@users.noreply.github.com>
1 parent 9d70fdb commit 302653a

File tree

2 files changed

+112
-4
lines changed

2 files changed

+112
-4
lines changed

.github/workflows/build-master.yml

Lines changed: 57 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,65 @@ jobs:
4141
report_paths: '**/build/test-results/test*/TEST-*.xml'
4242

4343
- name: Archive plugin jars on GitHub
44-
uses: actions/upload-artifact@v4
44+
uses: actions/upload-artifact@v7
4545
with:
4646
name: EssentialsX plugin jars
4747
path: jars/
4848

49+
- name: Upload EssentialsX jar
50+
uses: actions/upload-artifact@v7
51+
with:
52+
path: jars/EssentialsX-*.jar
53+
archive: false
54+
55+
- name: Upload EssentialsXAntiBuild jar
56+
uses: actions/upload-artifact@v7
57+
with:
58+
path: jars/EssentialsXAntiBuild-*.jar
59+
archive: false
60+
61+
- name: Upload EssentialsXChat jar
62+
uses: actions/upload-artifact@v7
63+
with:
64+
path: jars/EssentialsXChat-*.jar
65+
archive: false
66+
67+
- name: Upload EssentialsXDiscord jar
68+
uses: actions/upload-artifact@v7
69+
with:
70+
path: jars/EssentialsXDiscord-*.jar
71+
archive: false
72+
73+
- name: Upload EssentialsXDiscordLink jar
74+
uses: actions/upload-artifact@v7
75+
with:
76+
path: jars/EssentialsXDiscordLink-*.jar
77+
archive: false
78+
79+
- name: Upload EssentialsXGeoIP jar
80+
uses: actions/upload-artifact@v7
81+
with:
82+
path: jars/EssentialsXGeoIP-*.jar
83+
archive: false
84+
85+
- name: Upload EssentialsXProtect jar
86+
uses: actions/upload-artifact@v7
87+
with:
88+
path: jars/EssentialsXProtect-*.jar
89+
archive: false
90+
91+
- name: Upload EssentialsXSpawn jar
92+
uses: actions/upload-artifact@v7
93+
with:
94+
path: jars/EssentialsXSpawn-*.jar
95+
archive: false
96+
97+
- name: Upload EssentialsXXMPP jar
98+
uses: actions/upload-artifact@v7
99+
with:
100+
path: jars/EssentialsXXMPP-*.jar
101+
archive: false
102+
49103
- name: Deploy to Maven repo
50104
if: ${{ success() && github.event_name == 'push' && github.repository == 'EssentialsX/Essentials' && github.ref == 'refs/heads/2.x' }}
51105
env:
@@ -67,7 +121,7 @@ jobs:
67121
cp -r EssentialsXMPP/build/docs/javadoc/ javadocs/EssentialsXMPP/
68122
69123
- name: Archive Javadocs
70-
uses: actions/upload-artifact@v4
124+
uses: actions/upload-artifact@v7
71125
with:
72126
name: javadocs
73127
path: javadocs/
@@ -85,7 +139,7 @@ jobs:
85139
node-version: 22
86140

87141
- name: Download Javadocs
88-
uses: actions/download-artifact@v4
142+
uses: actions/download-artifact@v8
89143
with:
90144
name: javadocs
91145
path: javadocs/

.github/workflows/build-pr.yml

Lines changed: 55 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,61 @@ jobs:
4848
report_paths: '**/build/test-results/test*/TEST-*.xml'
4949

5050
- name: Archive plugin jars on GitHub
51-
uses: actions/upload-artifact@v4
51+
uses: actions/upload-artifact@v7
5252
with:
5353
name: EssentialsX plugin jars
5454
path: jars/
55+
56+
- name: Upload EssentialsX jar
57+
uses: actions/upload-artifact@v7
58+
with:
59+
path: jars/EssentialsX-*.jar
60+
archive: false
61+
62+
- name: Upload EssentialsXAntiBuild jar
63+
uses: actions/upload-artifact@v7
64+
with:
65+
path: jars/EssentialsXAntiBuild-*.jar
66+
archive: false
67+
68+
- name: Upload EssentialsXChat jar
69+
uses: actions/upload-artifact@v7
70+
with:
71+
path: jars/EssentialsXChat-*.jar
72+
archive: false
73+
74+
- name: Upload EssentialsXDiscord jar
75+
uses: actions/upload-artifact@v7
76+
with:
77+
path: jars/EssentialsXDiscord-*.jar
78+
archive: false
79+
80+
- name: Upload EssentialsXDiscordLink jar
81+
uses: actions/upload-artifact@v7
82+
with:
83+
path: jars/EssentialsXDiscordLink-*.jar
84+
archive: false
85+
86+
- name: Upload EssentialsXGeoIP jar
87+
uses: actions/upload-artifact@v7
88+
with:
89+
path: jars/EssentialsXGeoIP-*.jar
90+
archive: false
91+
92+
- name: Upload EssentialsXProtect jar
93+
uses: actions/upload-artifact@v7
94+
with:
95+
path: jars/EssentialsXProtect-*.jar
96+
archive: false
97+
98+
- name: Upload EssentialsXSpawn jar
99+
uses: actions/upload-artifact@v7
100+
with:
101+
path: jars/EssentialsXSpawn-*.jar
102+
archive: false
103+
104+
- name: Upload EssentialsXXMPP jar
105+
uses: actions/upload-artifact@v7
106+
with:
107+
path: jars/EssentialsXXMPP-*.jar
108+
archive: false

0 commit comments

Comments
 (0)