Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable saving of userdata files #5804

Open
TheFocusDevHUN opened this issue May 18, 2024 · 11 comments
Open

Add option to disable saving of userdata files #5804

TheFocusDevHUN opened this issue May 18, 2024 · 11 comments
Labels
type: enhancement Features and feature requests.

Comments

@TheFocusDevHUN
Copy link

Feature description

I'd like an option to disable saving of userdata files, preferably with a single boolean toggle, enabling it would stop the generation of userdata yaml files.

How the feature is useful

Some server network setups don't really need to persist Essentials userdata because they use EssentialsX mainly for its large command palette. They don't use the jail system or the economy part, etc. Instead, they use a cross-server currency system with a database. I want an option to disable saving of userdata files as this could save on disk space and probably on disk I/O as well.

@TheFocusDevHUN TheFocusDevHUN added the type: enhancement Features and feature requests. label May 18, 2024
@Evidentsinger14
Copy link
Member

If you don’t need EssentialsX to do anything, why use EssentialsX? What exactly are you using essx for if you’re not saving userdata.

@TheFocusDevHUN
Copy link
Author

TheFocusDevHUN commented May 18, 2024

If you don’t need EssentialsX to do anything, why use EssentialsX? What exactly are you using essx for if you’re not saving userdata.

In my setup, nearly everything that the plugin saves in these yaml files are just there for no reason. We use EssX for the command palette, not for jail, nor muting or banning players, etc. The problem with just removing the plugin alltogether is that Essentials is so common among staff members it is almost muscle memory so losing these would be inconvinient. I know that Essentials supposed to be a '"one plugin does it all" system when it comes to most server functions but it I think it was never meant to be used on server networks it is more like a "single server, all important functions" type of plugin. But it was adopted by many networks anyway.

@mbax
Copy link
Member

mbax commented May 18, 2024

Not an EssX dev here, just thinking. How big is your userdata folder, that you're worried about space? Similarly, IO should be tiny on this. It feels, at first glance, like this is microoptimization.

@mdcfe
Copy link
Member

mdcfe commented May 18, 2024

I'm not opposed to this option on principle, but I also don't see much of a compelling reason for us to support this. EssentialsX stores very minimal data on disk and does almost no reads/writes unless you use features that persist data (jails, homes, mutes etc). Any change to disable creating userdata files would require thorough testing, as this may have unforeseen consequences for commands that do expect persistent data.

@TheFocusDevHUN
Copy link
Author

Not an EssX dev here, just thinking. How big is your userdata folder, that you're worried about space? Similarly, IO should be tiny on this. It feels, at first glance, like this is microoptimization.

Currently the server in question is in development so not that big for now but imagine a network with let's say 1000+ players and Essentials is installed on every backend paper server so it creates a yml per player and per server for each and every one of them.. To me, that somehow sounds terrifying

@mbax
Copy link
Member

mbax commented May 18, 2024

Just Google Chrome has over 30 000 individual files stored in my AppData folder! None of this feels concerning. :)

@bDanno

This comment was marked as off-topic.

@mbax
Copy link
Member

mbax commented May 18, 2024

I like the simplicity of having yaml files, however, I do support the idea of essentialsX being able to store user data in a mysql database (optional, ofc - could be a config setting) <3

MySQL is not relevant to this issue. See #1265

@TheFocusDevHUN
Copy link
Author

I like the simplicity of having yaml files, however, I do support the idea of essentialsX being able to store user data in a mysql database (optional, ofc - could be a config setting) <3

Yes yml is simple because you can edit things by hand easily but when you have a dozen players and multiple servers, this simplicity becomes pointless. I think Yml was never intended to be a data store, it was created for configuration.

@bDanno

This comment was marked as off-topic.

@TheFocusDevHUN

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

No branches or pull requests

5 participants