Add tests and remove circular-json use #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests have been added to ensure the addMetaData method style behave the same once circular-json usage is replaced by the standard JSON methods.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 72.93% 72.88% -0.06%
==========================================
Files 3 3
Lines 532 531 -1
==========================================
- Hits 388 387 -1
Misses 144 144
Continue to review full report at Codecov.
|
|
Travis CI started the build 4d 3h 47m 56s ago... did I introduced an infinite loop somewhere by removing this dependency? |
|
Thats crazy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have been added to ensure the addMetaData method behave the same once circular-json usage is replaced by the standard JSON methods.