Skip to content

Fixes Issue #1437 #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

arnavgupta00
Copy link

@arnavgupta00 arnavgupta00 commented May 11, 2025

Not getting Last message in the findChats Endpoint

HOW DID I SOLVE IT

  1. REPLACED THE CURRENT lastMessage with the below snippet
const lastMessage = contact.lastmessageid
          ? {
              id: contact.lastmessageid,
              key: contact.lastmessage_key,
              pushName: contact.lastmessagepushname,
              participant: contact.lastmessageparticipant,
              messageType: contact.lastmessagemessageyype,
              message: contact.lastmessagemessage,
              contextInfo: contact.lastmessagecontextinfo,
              source: contact.lastmessagesource,
              messageTimestamp: contact.lastmessagemessagetimestamp,
              instanceId: contact.lastmessageinstanceid,
              sessionId: contact.lastmessagesessionid,
              status: contact.lastmessagestatus,
            }
          : undefined;


Summary by Sourcery

Bug Fixes:

  • Fix retrieval of the last message in the findChats endpoint by using the correct contact property names.

Copy link
Contributor

sourcery-ai bot commented May 11, 2025

Reviewer's Guide

This pull request fixes the retrieval of the last message in the findChats endpoint by updating the mapping logic to use the correct property names from the contact object, ensuring accurate last message data is returned.

File-Level Changes

Change Details Files
Updated the mapping of last message fields in the findChats endpoint to use the correct property names from the contact object.
  • Replaced camelCase property accessors with snake_case equivalents for last message fields.
  • Ensured all relevant last message fields are mapped from the correct contact properties.
  • Removed an unnecessary blank line at the end of the mappedResults block.
src/api/services/channel.service.ts

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@arnavgupta00 arnavgupta00 changed the title Fixed Issue #1437 Fixes #1437 May 11, 2025
@arnavgupta00 arnavgupta00 changed the title Fixes #1437 Fixes Issue #1437 May 11, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arnavgupta00 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@nestordavalos
Copy link
Contributor

nestordavalos commented May 12, 2025

Thank you for your contribution, but I've switched to the develop branch so your proposal can be analyzed.
Another thing, this correction has already been applied here. #1384

@DavidsonGomes DavidsonGomes changed the base branch from main to develop May 12, 2025 16:00
@DavidsonGomes
Copy link
Collaborator

fix lint issues please use npm run lint

@DavidsonGomes
Copy link
Collaborator

implementado na develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants